Server logs to panel #811

rwols · 2019-12-02T19:31:35Z

This works pretty good already.

Move forward with OutputPanel from sublime_lib? What to do about the mypy errors?
Should the server log panel be a circular buffer? It will append lines indefinitely now.
It appears attach_tcp_client was an unused function? I removed it.
Moved attachment of stderr to the WindowManager.

It only displays the last line now. It should become a circular buffer. Look into using sublime_lib.

Use the Panel class to toggle visibility

…anel It apparently has an infinite buffer so we should make that circular instead. You can click inside the panel and that screws up the output. Should not make it interactive.

No need for set_read_only anymore

…tputPanel

It is no longer used.

It is unused.

rchl · 2019-12-02T20:42:34Z

So this will split server logs only? Does it means that it will be hard to correlate specific server messages with the protocol communication? I would sometimes do console.error() calls in a server to debug something.

I would love to have to have all LSP-related logs in one single panel and be able to decide what kind of logs should be shown there (protocol / server / etc. - could be done with a bitmask).

tomv564 · 2019-12-03T13:17:15Z

Yeah, correlating server output to payloads is nice, we could perhaps always have them in a server log panel?

The main console should then only contain LSP logging about package initialisation, configuration and failures to start servers - things new users would be most interested in.

Another thought - if you are running 2 servers in a given window, it becomes somewhat painful to identify which messages came from which server. We could create an output panel per running configuration?

tomv564

Really nice work.

Curious about your thoughts about OutputPanel, assuming we solve the import/typing issue, did it save us complexity?

plugin/core/windows.py

plugin/core/rpc.py

plugin/core/windows.py

plugin/diagnostics.py

plugin/panels.py

…e_lib.OutputPanel" This reverts commit 558f489.

…tPanel" This reverts commit d539380.

This reverts commit c8867c4.

This reverts commit 7b83acf.

The command modifies the panel atomically, preventing jankyness

They are too large and ST will refuse to syntax-highlight long lines anyway.

So that keybindings with a context keep working if the user's cursor is in the panel somewhere.

tomv564

Since this became a rather large pull request I looked at some things that jumped out at me. Looking forward to having another look after!

plugin/core/panels.py

plugin/panels.py

boot.py

plugin/core/main.py

plugin/core/panels.py

plugin/core/settings.py

plugin/core/windows.py

Conflicts: plugin/core/process.py plugin/core/sessions.py plugin/core/test_windows.py plugin/core/windows.py

Instead, we have a logger class now with methods such as outgoing_request, incoming_request. The WindowManager modifies the eventual log sink of that object so that it'll log to a panel. Interestingly, this also makes it easy to log to the console again.

plugin/core/rpc.py

tomv564

Nice changes in the last round!
I'd still like to avoid the deprecation of LspShowDiagnosticsPanelCommand, but otherwise it's ready to merge!

rwols · 2019-12-19T17:04:42Z

Perhaps we can do an int(payload["id"]) if "id" in payload else None or something?

You're right...

Nice changes in the last round!

Thanks!

I'd still like to avoid the deprecation of LspShowDiagnosticsPanelCommand, but otherwise it's ready to merge!

I was about to write this, hold on for just this evening :)

rwols added 15 commits December 2, 2019 16:10

Implement a general-purpose panel toggler commmand

35c587c

Replace 'lsp_show_diagnostics_panel' with 'lsp_toggle_panel'

13681ce

Working towards logging to a panel

5c0a981

It only displays the last line now. It should become a circular buffer. Look into using sublime_lib.

Add sublime_lib dependency

7b33477

First steps with sublime_lib

2211232

Use the Panel class to toggle visibility

Use an OutputPanel from sublime_lib to print server messages to the p…

e0e67ca

…anel It apparently has an infinite buffer so we should make that circular instead. You can click inside the panel and that screws up the output. Should not make it interactive.

Force writes, seek cursor to end before writing logs

963e95e

No need for set_read_only anymore

Convert the panel handling in references.py to using an OutputPanel

d539380

Convert te panel handling in diagnostics.py to using a sublime_lib.Ou…

558f489

…tputPanel

Remove unused import

7f4b8c8

All our panels are read-only

2162c1e

Don't forget to destroy the server log panel when the plugin is disabled

5cb71ff

Remove LspClearPanelCommand

7b83acf

It is no longer used.

Remove LspUpdatePanelCommand

c8867c4

It is no longer used.

Remove the server_log function

18e03ab

It is unused.

tomv564 requested changes Dec 3, 2019

View reviewed changes

rwols added 12 commits December 4, 2019 18:36

Merge branch 'master' into feature/server-logs-to-panel

1ffbde1

Fix error invoking log_callback during merge

9621225

Rework lsp_toggle_panel command

91ad2c7

Revert "Convert te panel handling in diagnostics.py to using a sublim…

a401798

…e_lib.OutputPanel" This reverts commit 558f489.

Revert "Convert the panel handling in references.py to using an Outpu…

0dff79e

…tPanel" This reverts commit d539380.

Revert "Remove LspUpdatePanelCommand"

e4c6675

This reverts commit c8867c4.

Revert "Remove LspClearPanelCommand"

2b1503f

This reverts commit 7b83acf.

Replace OutputPanel with lsp_update_server_panel command

85c566e

The command modifies the panel atomically, preventing jankyness

Print LSP payloads to the server panel

c7a53e2

Align notifications with the other payload types ('<-- ' vs. '<--')

2b84d05

Syntax highlight the server logs panel

bb01fea

Do not print the payloads of textDocument/did{Change,Open}

048042b

They are too large and ST will refuse to syntax-highlight long lines anyway.

Put "lsp_active": True in all panels

cf70d00

So that keybindings with a context keep working if the user's cursor is in the panel somewhere.

tomv564 requested changes Dec 17, 2019

View reviewed changes

rwols added 8 commits December 17, 2019 19:20

Merge branch 'master' into feature/server-logs-to-panel

fb1cd3c

Don't modify settings.py

9ae3f3e

Minimally modify boot.py

cbe8c6c

Compactify imports

11b5452

Remove debug printing trying to figure out how panels are unloaded

fe5f2b8

Merge branch 'master' into feature/server-logs-to-panel

86fb529

Conflicts: plugin/core/process.py plugin/core/sessions.py plugin/core/test_windows.py plugin/core/windows.py

Just remove the Payload type entirely and replace with Any

c6dd8b5

rwols commented Dec 18, 2019

View reviewed changes

plugin/core/rpc.py Show resolved Hide resolved

tomv564 requested changes Dec 19, 2019

View reviewed changes

rwols added 4 commits December 19, 2019 18:47

Merge branch 'master' into feature/server-logs-to-panel

b77efa3

Just write two separate commands for the panel togglers

f9c990d

Fix overindentation

178295c

Ensure an int for request_id in rpc.py, it might be a string!

a9f385d

This was referenced Dec 19, 2019

Fix: use a mutex when printing to the console #558

Closed

Print race condition #557

Closed

tomv564 previously approved these changes Dec 20, 2019

View reviewed changes

rwols added 2 commits December 21, 2019 09:41

Merge branch 'master' into feature/server-logs-to-panel

384f3a3

struck by flakiness yet again

062f571

rwols dismissed tomv564’s stale review via 062f571 December 21, 2019 08:46

rwols requested a review from tomv564 December 21, 2019 08:47

rwols closed this Dec 21, 2019

rwols reopened this Dec 21, 2019

tomv564 approved these changes Dec 21, 2019

View reviewed changes

tomv564 merged commit cdfc434 into master Dec 21, 2019

ayoub-benali mentioned this pull request Dec 21, 2019

Update Sublime settings regarding window/showMessage scalameta/metals#1218

Merged

rwols deleted the feature/server-logs-to-panel branch December 21, 2019 22:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Server logs to panel #811

Server logs to panel #811

rwols commented Dec 2, 2019

rchl commented Dec 2, 2019

tomv564 commented Dec 3, 2019

tomv564 left a comment

tomv564 left a comment

tomv564 left a comment

rwols commented Dec 19, 2019

Server logs to panel #811

Server logs to panel #811

Conversation

rwols commented Dec 2, 2019

rchl commented Dec 2, 2019

tomv564 commented Dec 3, 2019

tomv564 left a comment

Choose a reason for hiding this comment

tomv564 left a comment

Choose a reason for hiding this comment

tomv564 left a comment

Choose a reason for hiding this comment

rwols commented Dec 19, 2019