Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cloudPorts into cloudOptions #417

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

skitt
Copy link
Member

@skitt skitt commented Dec 2, 2022

Now that we have a data structure for cloud options, use it for all options.

Signed-off-by: Stephen Kitt skitt@redhat.com

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr417/skitt/cloudports-cloudoptions
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

Now that we have a data structure for cloud options, use it for all
options.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Dec 6, 2022
@Jaanki Jaanki enabled auto-merge (rebase) December 6, 2022 05:08
@Jaanki Jaanki merged commit 030ad74 into submariner-io:devel Dec 6, 2022
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr417/skitt/cloudports-cloudoptions]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants