Backport: Support diagnose tunnel on previous Submariner releases #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some minor changes to the code, we will be able to support running subctl diagnose tunnel command on previous Submariner releases where NAT discovery is not enabled (or NAT discovery is still in progress). Signed-Off-by: Sridhar Gaddam <sgaddam@redhat.com> (cherry picked from commit 5e5126c)
sridhargaddam
requested review from
mangelajo,
Oats87,
skitt and
tpantelis
as code owners
|
🤖 Created branch: z_pr1507/sridhargaddam/fix-diagnose |
sridhargaddam
changed the title
tpantelis
approved these changes
Jul 21, 2021
mangelajo
approved these changes
Jul 21, 2021
|
🤖 Closed branches: [z_pr1507/sridhargaddam/fix-diagnose] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some minor changes to the code, we will be able to support running
subctl diagnose tunnel command on previous Submariner releases where
NAT discovery is not enabled (or NAT discovery is still in progress).
Signed-Off-by: Sridhar Gaddam sgaddam@redhat.com
(cherry picked from commit 5e5126c)