Backport: Fix subctl diagnose hostname mismatch issue #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sridhargaddam
requested review from
mangelajo,
Oats87,
skitt and
tpantelis
as code owners
|
🤖 Created branch: z_pr1508/sridhargaddam/bp-diagnose-active-gw |
sridhargaddam
changed the title
mangelajo
reviewed
Jul 21, 2021
pkg/subctl/cmd/validate_tunnel.go
Outdated
| @@ -191,7 +191,15 @@ func getGatewayIP(remoteCfg *rest.Config, localClusterID string) string { | |||
|
|
|||
| for _, conn := range gw.Status.Connections { | |||
| if conn.Endpoint.ClusterID == localClusterID { | |||
| return conn.UsingIP | |||
| if conn.UsingIP != "" { | |||
There was a problem hiding this comment.
Isn't this part a leak of the above PR ?
There was a problem hiding this comment.
Oh yes. As you might have noticed the directory structure and file-names are changed between release-0.9 and devel. So I could not do a clean cherry-pick and had to do manual changes.
Just to be sure that changes are not causing regression, I manually built subctl and verified it locally on a KIND cluster. In that process, I was getting this error, so included it and test-cases passed. I forgot to remove it ;-)
I'll update this PR and will remove this change.
Thanks for reviewing @mangelajo
Submariner Endpoint stores the hostname info as part of the endpoint object. In most of the K8s clusters, the hostname matches with the nodeName, but on some clusters, it was seen that nodeName does not match. This PR fixes this issue. Also, when more than a single node is labelled as Gateway node, the current code was not handling it properly, this PR fixes it. Fixes issue: submariner-io#1471 Signed-Off-by: Sridhar Gaddam <sgaddam@redhat.com> (cherry picked from commit 9d125f0)
sridhargaddam
force-pushed
the
bp-diagnose-active-gw
branch
from
6c069a7
to
44b4734
Compare
tpantelis
approved these changes
Jul 23, 2021
nyechiel
approved these changes
Jul 27, 2021
|
🤖 Closed branches: [z_pr1508/sridhargaddam/bp-diagnose-active-gw] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submariner Endpoint stores the hostname info as part of the endpoint object.
In most of the K8s clusters, the hostname matches with the nodeName, but on
some clusters, it was seen that nodeName does not match. This PR fixes this
issue.
Also, when more than a single node is labelled as Gateway node, the current
code was not handling it properly, this PR fixes it.
Fixes issue: #1471
Signed-Off-by: Sridhar Gaddam sgaddam@redhat.com
(cherry picked from commit 9d125f0)