Rename Moonbeam datasource processor #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the ds kinds are changed as well, it will break legacy projects. Re-exporting isn't enough. I think it need to be either we add the original moonbeam kind as an alias, or we just make it clear a breaking change (and bump version). |
|
Regards naming, i feel we can make it more clear by changing |
|
Please also merge this in when we complete the rename subquery/documentation#71 |
|
We should also update the sample project https://github.com/subquery/tutorials-moonriver-evm-starter |
The datasource processor seems to apply to Frontier so its better to have the general name. Also re-exports Frontier as Moonbeam for backwards compatibility.
stwiname
force-pushed
the
rename-moonbeam-ds
branch
from
bdd03ab
to
553b142
Compare
bz888
pushed a commit
that referenced
this pull request
Jun 3, 2022
* Rename Moonbeam datasource processor The datasource processor seems to apply to Frontier so its better to have the general name. Also re-exports Frontier as Moonbeam for backwards compatibility. * Clean up, fix moonbeam alias * Fix MoonbeamCall/Event generics * add default export Co-authored-by: JQQQ <jiqiang90@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datasource processor seems to apply to Frontier so its better to use Frontier as the name.
Also re-exports Frontier as Moonbeam for backwards compatibility.