-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux support #70
Linux support #70
Conversation
defos/src/defos.cpp
Outdated
@@ -4,9 +4,6 @@ | |||
|
|||
#define DLIB_LOG_DOMAIN LIB_NAME | |||
#include <dmsdk/sdk.h> | |||
|
|||
#if defined(DM_PLATFORM_OSX) || defined(DM_PLATFORM_WINDOWS) || defined(DM_PLATFORM_HTML5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do this. It should still work on Android and iOS. Just add another || defined(DM_PLATFORM_LINUX)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, i forgot those platform...
finally complete some functions that I can, and it is really a worse experience to touch X11... |
Also i develop and test on Manjaro linux, need help to test on other pop linux. |
From sdl source code, Here contains most of functions that we need. |
What is still missing here for the merge? Can I help out with anything? |
@linuxfranz There's a merge conflict that needs to be solved, and then I guess it's as @chaosddp writes in a previous post, the branch needs testing on more Linux distros. |
The merge conflict is extremely minor, just one line. |
Tested on OpenSuSe Tumbleweed and Mageia 6. Toggle fullscreen works like a charm. |
Merge it if there is no reason not to. @chaosddp ? |
@subsoap i did not merge it since there still some features not implemented, but it is OK to merge, may be later @dapetcu21 or someone else can help to finish them. |
@linuxfranz @subsoap I just merged the PR, and sorry for late response, as just back from vocation :) |
@linuxfranz if you want to help please refer to #37, i list the missing features there. |
I created a branch to add Linux support, it only support set_title now. I will update slowly, as i am not familiar with X11 and Linux, and need your help! :)