Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux support #70

Merged
merged 16 commits into from
May 7, 2018
Merged

Linux support #70

merged 16 commits into from
May 7, 2018

Conversation

chaosddp
Copy link
Collaborator

I created a branch to add Linux support, it only support set_title now. I will update slowly, as i am not familiar with X11 and Linux, and need your help! :)

@chaosddp chaosddp mentioned this pull request Feb 27, 2018
@@ -4,9 +4,6 @@

#define DLIB_LOG_DOMAIN LIB_NAME
#include <dmsdk/sdk.h>

#if defined(DM_PLATFORM_OSX) || defined(DM_PLATFORM_WINDOWS) || defined(DM_PLATFORM_HTML5)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this. It should still work on Android and iOS. Just add another || defined(DM_PLATFORM_LINUX)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, i forgot those platform...

@chaosddp
Copy link
Collaborator Author

chaosddp commented Mar 3, 2018

finally complete some functions that I can, and it is really a worse experience to touch X11...

@chaosddp
Copy link
Collaborator Author

chaosddp commented Mar 5, 2018

Also i develop and test on Manjaro linux, need help to test on other pop linux.

@chaosddp
Copy link
Collaborator Author

chaosddp commented Mar 5, 2018

From sdl source code, Here contains most of functions that we need.

@linuxfranz
Copy link

What is still missing here for the merge? Can I help out with anything?

@britzl
Copy link
Collaborator

britzl commented Apr 29, 2018

@linuxfranz There's a merge conflict that needs to be solved, and then I guess it's as @chaosddp writes in a previous post, the branch needs testing on more Linux distros.

@subsoap
Copy link
Owner

subsoap commented Apr 29, 2018

The merge conflict is extremely minor, just one line.

@linuxfranz
Copy link

Tested on OpenSuSe Tumbleweed and Mageia 6. Toggle fullscreen works like a charm.

@subsoap
Copy link
Owner

subsoap commented May 3, 2018

Merge it if there is no reason not to. @chaosddp ?

@chaosddp
Copy link
Collaborator Author

chaosddp commented May 7, 2018

@subsoap i did not merge it since there still some features not implemented, but it is OK to merge, may be later @dapetcu21 or someone else can help to finish them.

@chaosddp chaosddp merged commit fa0897d into subsoap:master May 7, 2018
@chaosddp
Copy link
Collaborator Author

chaosddp commented May 7, 2018

@linuxfranz @subsoap I just merged the PR, and sorry for late response, as just back from vocation :)

@chaosddp
Copy link
Collaborator Author

chaosddp commented May 7, 2018

@linuxfranz if you want to help please refer to #37, i list the missing features there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants