New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Human-readable names for text-type properties through SwitchTextTypeTool #264
Conversation
Don't merge. I forgot some edge cases. |
Now we are good I think. |
I think it is fine as a quick-fix. Just as quick estimation: probably we want to update the label independently from the dropdown. |
I will try it out first before merging. |
We need to iterate on this one. It was the first time I could check now and it seems broken. I.e., while it shows the context now, it doesn't let me switch type elsewhere. |
@michael attention, I have rebase to latest master. So do a reset to FETCH_HEAD. |
Well, I have reviewed it yesterday. It didn't work for me. Should this have changed? don't see commits... |
ahh sorry you mean the refinement... |
I solved the categorization stuff here in this branch. |
Works.. also switch text type. |
Human-readable names for text-type properties through SwitchTextTypeTool
We abuse the SwitchTextTypeTool a bit here, since this functionality is not directly related to text type switching. However it's a perfect place to show that information. One 'flaw' is that I had to activate the SwitchTextTypeCommand for all property editors (titleEditor, abstractEditor). I think it does the job for now, but we should seek for a more consistent solution eventually.