Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human-readable names for text-type properties through SwitchTextTypeTool #264

Merged
merged 5 commits into from Nov 20, 2015

Conversation

michael
Copy link
Member

@michael michael commented Nov 19, 2015

We abuse the SwitchTextTypeTool a bit here, since this functionality is not directly related to text type switching. However it's a perfect place to show that information. One 'flaw' is that I had to activate the SwitchTextTypeCommand for all property editors (titleEditor, abstractEditor). I think it does the job for now, but we should seek for a more consistent solution eventually.

@michael michael added this to the Beta 2 milestone Nov 19, 2015
@michael
Copy link
Member Author

michael commented Nov 19, 2015

Don't merge. I forgot some edge cases.

@michael
Copy link
Member Author

michael commented Nov 19, 2015

Now we are good I think.

@obuchtala
Copy link
Member

I think it is fine as a quick-fix.
We will try to find a proper solution to it in future.

Just as quick estimation: probably we want to update the label independently from the dropdown.
I.e., the label could be part of a different package, which SwitchTextType would depend on.
So that we don't need to activate the switch tool to show the label. But don't know yet how to do that.

@obuchtala
Copy link
Member

I will try it out first before merging.

@obuchtala
Copy link
Member

We need to iterate on this one. It was the first time I could check now and it seems broken.

I.e., while it shows the context now, it doesn't let me switch type elsewhere.

@obuchtala
Copy link
Member

@michael attention, I have rebase to latest master. So do a reset to FETCH_HEAD.

@michael michael mentioned this pull request Nov 20, 2015
@obuchtala
Copy link
Member

Well, I have reviewed it yesterday. It didn't work for me. Should this have changed? don't see commits...

@obuchtala
Copy link
Member

ahh sorry you mean the refinement...

@michael
Copy link
Member Author

michael commented Nov 20, 2015

I solved the categorization stuff here in this branch.

48eec04

@obuchtala
Copy link
Member

Works.. also switch text type.
U can merge.

michael pushed a commit that referenced this pull request Nov 20, 2015
Human-readable names for text-type properties through SwitchTextTypeTool
@michael michael merged commit 222d62d into master Nov 20, 2015
@obuchtala obuchtala deleted the issue-243 branch November 28, 2015 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants