Initial support for X-EconomicAppIdentifier #42
Conversation
| @@ -8,6 +8,10 @@ class Economic::Endpoint | |||
| def_delegator "client.globals", :log_level, :log_level= | |||
| def_delegator "client.globals", :log, :log= | |||
|
|
|||
| def initialize(app_identifier = nil) | |||
There was a problem hiding this comment.
Can we add some documentation about what app_identifier is meant to be? Has E-conomic written something somewhere we can copy/paste and/or link to?
There was a problem hiding this comment.
Will do. My preference would be to add the link to the blog post in the commit message and add a note to the README - sound good?
There was a problem hiding this comment.
A note in the README sounds good. I'd prefer some rdoc-style documentation directly in the code above the method definition if possible. See for example #call below. This way the docs will appear on for example http://www.rubydoc.info/gems/rconomic/Economic/Endpoint
You can now supply an identifier for your application to both `Economic::Session.new` and `#connect_with_credentials`. Economic's blog post about this requirement can be found at http://techtalk.e-conomic.com/e-conomic-soap-api-now-requires-you-to-specify-a-custom-x-economicappidentifier-header/
prognostikos
force-pushed
the
app-identifier
branch
from
15cb2f5
to
4fadb0b
Compare
|
@koppen OK, I think it's pretty well documented now. |
|
Er, well, |
prognostikos
force-pushed
the
app-identifier
branch
from
7818e1b
to
1972e21
Compare
|
That's great, thanks! |
Initial support for X-EconomicAppIdentifier
So here's a somewhat hacky solution.
I couldn't easily see how to test if request headers are set when mocking requests, but I have run this on a production batch job that uses
connect_with_credentialsand it does work for me.