Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/rewrite markup and CSS #8

Open
2 of 3 tasks
jessevondoom opened this issue Sep 5, 2020 · 0 comments
Open
2 of 3 tasks

Review/rewrite markup and CSS #8

jessevondoom opened this issue Sep 5, 2020 · 0 comments
Labels
planning 🚀 Early thinking that could lead to more issues priority: standard 🧨 This work is planned and committed to, on standard timelines and schedules

Comments

@jessevondoom
Copy link
Collaborator

jessevondoom commented Sep 5, 2020

The Lodge CSS and markup needs a deep inspection at least, but likely a rewrite. It works mostly fine right now, but it can likely be done with less markup/rules and a better semantic flow. Tighter type styles for the overlay are needed, we should add some standardized buttons for a few situations, and ultimately this sets the stage for any changes from the checkout flow UX work.

A lot of this will get broken out into multiple tickets but as an overview:

  • Core overlay markup and CSS
    • A 100% x 100% overlay background that will scroll on overflow. (We disable overflow on the body and capture it when the overlay is open, returning it as the overlay is closing. This keeps scroll positions constant and gives the ability to show longer content like a checkout receipt in a nicely scrolling overlay.)
    • A close button in the upper right corner, some animation effects on hover, not present in modal mode
    • A content/presentation space, semi floated center/center with the ability to grow vertically as needed
    • Add markup and styles for hidden-by-default OK/Cancel buttons for modal, close button for messaging
    • Remove as many wrappers and non-semantic elements as possible from markup
  • Type/input styles
    • Opinionated base font and type styles (can be overridden, but only with !important so it doesn't happen accidentally)
    • Styles for h2/h3/labels/buttons/inputs
  • Review markup and styles for checkout, input modules
    • Get all the canned experiences up to the same standard as the overlay itself
@jessevondoom jessevondoom changed the title Review/rewrite the CSS (especially overlay) Review/rewrite markup and CSS Dec 19, 2020
@jessevondoom jessevondoom added planning 🚀 Early thinking that could lead to more issues priority: standard 🧨 This work is planned and committed to, on standard timelines and schedules labels Dec 19, 2020
jessevondoom added a commit that referenced this issue Jan 10, 2021
Got things looking/working as they should with the text and color styles in the overlay. Certainly relevant to #8, though I still think we need to really examine the current structure. Flexbox would cut CSS/markup for this stuff in half.
jessevondoom added a commit that referenced this issue Jan 16, 2021
...ive had a half-scrawled "need to fix up the CSS" plan for ages and better class naming has been on there for a while. BEM was the likely target and today @fricto reminded me to circle back. This isn't a proper clean-up, but enough that public-facing stuff should be better off!

Gets us a little closer on #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
planning 🚀 Early thinking that could lead to more issues priority: standard 🧨 This work is planned and committed to, on standard timelines and schedules
Projects
None yet
Development

No branches or pull requests

1 participant