Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update local relay and parachain tutorials, All docs to polkadot-v0.9.24 version #1140

Merged
merged 26 commits into from Jun 27, 2022
Merged

Update local relay and parachain tutorials, All docs to polkadot-v0.9.24 version #1140

merged 26 commits into from Jun 27, 2022

Conversation

NukeManDan
Copy link
Contributor

@NukeManDan NukeManDan commented Jun 17, 2022 •
edited

  • Fix media files used
    • NOTE: the chain specs are listing a URL that will only be correct after merging!
  • Rpdate chain specs v0.9.24 ONLY in these files, once merged ALL docs should be updated to this version!
  • Reorder for relay tuto and para tuto separation
  • Remove unused files
    • NOTE: connect to EVM should be establied somehwere else - this is fundementally not about "conneting to other chains", it's about Frontier.
  • nav updates for files that are ready
  • staging file that are WIP
  • glossary additions needed for these pages

@NukeManDan
fix links
29ef97d 
fix media
update chain specs v0.9.24
reorder for relay tuto and para tuto seporation
@NukeManDan NukeManDan marked this pull request as draft June 17, 2022 00:15
@netlify
Copy link

netlify bot commented Jun 17, 2022 •
edited

✅ Deploy Preview for substrate-docs-md ready!

Name Link
🔨 Latest commit e890ac0
🔍 Latest deploy log https://app.netlify.com/sites/substrate-docs-md/deploys/62b24fcf73b0210009209e16
😎 Deploy Preview https://deploy-preview-1140--substrate-docs-md.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NukeManDan NukeManDan self-assigned this Jun 17, 2022
@NukeManDan NukeManDan mentioned this pull request Jun 17, 2022
Closed
@NukeManDan
Remove unused files
236d0d1 
nav updates
glossary additions
@NukeManDan NukeManDan marked this pull request as ready for review June 17, 2022 17:34
lisa-parity
lisa-parity reviewed Jun 17, 2022
View reviewed changes
Copy link
Contributor

@lisa-parity lisa-parity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many files to look at but some suggestions.

content/md/en/docs/reference/glossary.md Outdated Show resolved Hide resolved
content/md/en/docs/reference/glossary.md Outdated Show resolved Hide resolved
content/md/en/docs/reference/glossary.md Outdated Show resolved Hide resolved
content/md/en/docs/reference/glossary.md Outdated Show resolved Hide resolved
content/md/en/docs/reference/how-to-guides/parachains/add-paranodes.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/parachain.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/parachain.md Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/parachain.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/parachain.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/parachain.md Outdated Show resolved Hide resolved
NukeManDan and others added 3 commits June 17, 2022 16:49
@NukeManDan @lisa-parity
Update content/md/en/docs/tutorials/connect-other-chains/parachain.md
c3d0bd4 
Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
@NukeManDan @lisa-parity
Update content/md/en/docs/tutorials/connect-other-chains/parachain.md
002de7a 
Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
@NukeManDan @lisa-parity
Apply suggestions from code review
84363b5 
Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
@NukeManDan NukeManDan linked an issue Jun 17, 2022 that may be closed by this pull request
<Image is missing> in upcoming version of Cumulus workshop tutorial #1102
Closed
NukeManDan and others added 5 commits June 20, 2022 15:04
@NukeManDan
res -> chain-specs
19df4cf
@NukeManDan
tweak
fd92c4d
@NukeManDan
#ss58-address-format
cb8f7b3
@NukeManDan @lisa-parity
Update content/md/en/docs/tutorials/connect-other-chains/local-relay.md
ccf9269 
Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
@NukeManDan @lisa-parity
Update content/md/en/docs/tutorials/connect-other-chains/local-relay.md
51998cf 
Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
@NukeManDan NukeManDan mentioned this pull request Jun 21, 2022
Open
@netlify
Copy link

netlify bot commented Jun 23, 2022 •
edited

✅ Deploy Preview for substrate-docs ready!

Name Link
🔨 Latest commit f4a87ad
🔍 Latest deploy log https://app.netlify.com/sites/substrate-docs/deploys/62b9f9ab7f250700088e1135
😎 Deploy Preview https://deploy-preview-1140--substrate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NukeManDan NukeManDan mentioned this pull request Jun 24, 2022
Merged
lisa-parity
lisa-parity suggested changes Jun 24, 2022
View reviewed changes
content/md/en/docs/tutorials/connect-other-chains/local-relay.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/local-relay.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/local-relay.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/parachain.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/parachain.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/rococo-slot.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/rococo-slot.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/rococo-slot.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/rococo-slot.md Outdated Show resolved Hide resolved
content/md/en/docs/tutorials/connect-other-chains/rococo-slot.md Outdated Show resolved Hide resolved
@NukeManDan NukeManDan mentioned this pull request Jun 24, 2022
Closed
@NukeManDan NukeManDan linked an issue Jun 24, 2022 that may be closed by this pull request
Broken Links in tutorial #1162
Closed
NukeManDan and others added 2 commits June 24, 2022 16:31
@NukeManDan @lisa-parity
Apply suggestions from code review
1a30cf6 
Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
@NukeManDan @lisa-parity
Update content/md/en/docs/reference/how-to-guides/parachains/add-para…
828399f 
…nodes.md

Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
This was referenced Jun 25, 2022
Closed
Closed
@NukeManDan NukeManDan changed the title Update local relay and parachain tutorials Update local relay and parachain tutorials, All docs to polkadot-v0.9.24 version Jun 27, 2022
@NukeManDan NukeManDan merged commit 31e5b2c into main Jun 27, 2022
@NukeManDan NukeManDan deleted the ds/connect-review branch June 27, 2022 18:52
This was referenced Jun 27, 2022
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsgunnlsgunn lsgunnlsgunn lsgunnlsgunn left review comments

@lisa-parity lisa-parity Awaiting requested review from lisa-parity

Assignees

@NukeManDan NukeManDan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken Links in tutorial <Image is missing> in upcoming version of Cumulus workshop tutorial
3 participants
@NukeManDan @lsgunnlsgunn @lisa-parity