New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting problems #623
Fix formatting problems #623
Conversation
@maltekliemann - Thanks for this! Curious: did you fun a formatting tool to do this? Need to run the PR locally to double check, but looks good to me. |
@sacha-l No, unfortunately, this had to be done by hand (except for replacing tabs with spaces). For example, you can't correct the indentation of enumeration items with a formatter - how is the formatter supposed to know where the indentation starts/ends? :) |
Cool - Yeah ! Unfortunately there is no ideal way to do this and although prettier is sometimes useful, other times it completely messes things up 🥶 🤷🏻 |
…er-hub/sl/fix-storage-info-in-tuts Fix tutorials write-ups
…er-hub/sl/minor-subwasm-updates Add nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much better this way, thanks again.
Glad I could help! 👍 |
Just resolving merge conflicts. |
Update: resolved most merge conflicts with the exception of |
This should fix the merge conflict. No idea why the CI fails now. I'll get on replacing the spaces with tabs, and I'll use the option that's not broken by prettier (see above). |
So what's going on with #666? |
Check links unfortunately fails always due to docer CI auth keys not being available for non-org members 🙄 safe to ignore, but we should check locally for sure if you touched URLs anywhere. |
yarn fmt:docs not used, prettier on each page modified here only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a yarn fmt
and hand cleaned all files to work at aminimum with this cc @sacha-l please remember to run this in your PRs moving forward ;)
I also ran yarn server:fresh
and the yarn checklinks
locally - found a broken img too.
ummmm wtf? I did not merge this. Now it's missing things. This automation @sacha-l for |
https://github.com/substrate-developer-hub/substrate-docs/commits/develop somehow it's right here. 🤷 Please do target |
Thanks! 👍 I'll check out the guide and will try to keep up the contributions as I learn! |
While reading the docs, I noticed some formatting problems and went down the rabbit hole:
I've also noticed that running
prettier
on some of the files significantly changes some code, like that following<Message
expressions. Is this indented? I have not committed the changes proposed by the auto-formatter.