Config with semistandard eslint and passing all tests

[jimmychu0807]

Updated to use strict semistandard.

According to doc, there are quite some dev-dependencies to be installed to make this work.

[shawntabrizi]

Should we add a follow up issue to enable CI on this repository?

[riusricardo]

@shawntabrizi CI will be very helpful on this repo for testing builds. Are you thinking on creating React tests? or just want to validate that it is not broken.

[shawntabrizi]

See: #10

Ideally we create react tests, and even some more practical ones where we connect to the dev-node and make transactions??

@jimmychu0807 what do I need to do to use this linting?

[jimmychu0807]

@shawntabrizi
You don't need to do anything, when running yarn start, it compile and lint your code.

If you want to let the linter auto-fix (which pretty much fix 90% of issues), run yarn semistandard --fix.

[JoshOrndorff]

@jimmychu0807 Hope this isn't a dumb question, but I can't seem to get this working.

1. Pull latest master
2. Introduce some should-be linting errors (like missing semicolons, double-quoted strings, etc)
3. Save files
4. yarn start
5. No errors or warnings in the terminal or console

I remember you previously said my attempt was only for editor integration is that true here too? If so, how will we be able to use this with CI?

Edit: Aha, I had to yarn install --dev first or else the linting was silently skipped.

[jimmychu0807]

@JoshOrndorff

• right, you need to do a yarn install, to install the new dependencies. So it works for you now?
• I was wrong. With the new EXTEND_ESLINT=true, the linting check actually also reflects in browser and terminal. And semistandard by default returns error (not warning) when failing their tests.
• you can also do yarn lint now just for linting. So we can put linting check as part of the CI workflow.

[JoshOrndorff]

Yes it works for me now including browser and terminal. Great job!