perf: optimize solidity verification contract #720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tamir Hemo <tamir@succinct.xyz> Co-authored-by: Ubuntu <ubuntu@ip-172-31-74-90.ec2.internal> Co-authored-by: Kevin Jue <kjue235@gmail.com> Co-authored-by: Tarik Moon <tarik@tarikmoon.com> Co-authored-by: Matthias Görgens <matthias.goergens@gmail.com> Co-authored-by: Eugene Rabinovich <eugene@succinct.xyz>
|
Great! Thank you :) We definitely haven't optimized the contract yet. |
|
It might sense to merge this PR once we add foundry testing to CI. |
|
We switched to a PLONK prover, which no longer requires this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was looking at the
sp1-project-templateI spotted some ways to optimize the contract a bit more and simplify it a bit at the same time. I followed the source of the contract back to this repo.The following is the gas change for the tests when the changes are applied to the template repository: