chore: make linter and clippy happy #793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest reviewing this via re-running the same commands against |
matthiasgoergens
changed the title
matthiasgoergens
changed the title
matthiasgoergens
changed the title
Via repeated application of ```bash cargo fix --allow-dirty cargo clippy --allow-dirty --fix --all -- -D warnings -D clippy::pedantic cargo fmt ```
matthiasgoergens
force-pushed
the
matthias/make-clippy-even-happier
branch
from
fc5e634
to
82fe4e4
Compare
matthiasgoergens
changed the title
jtguibas
approved these changes
May 23, 2024
jtguibas
approved these changes
May 23, 2024
|
It seems like CI fails for some reason. I will investigate. |
|
Looks like your clippy version has more suggestions. You can probably just ask it for automated fixes? |
auto-merge was automatically disabled
May 24, 2024 00:33
Merge queue setting changed
|
Closing this for now as the branch has gotten a bit out of sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via repeated application of
until we reach a fixed point.