-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom button types (dropdown, toggle, checkbox, radio) #43
Comments
What happens when you click that button? Does a dropdown menu popup? Is it a custom menu or a native select menu? Can you supply an use-case. Also, what app is that screenshot from? |
@jerone it's webstorm, and use-case is a build system. Select allows you choose which build system you gonna run, and other buttons is "run" and "debug". |
👍 I like this. |
Custom button types (dropdown, checkbox, radio) are definitely something that tool-bar should support. 👍 |
@suda commented on 26 mei 2015 12:44 CEST:
I do agree. I was thinking for the select/dropdown to use the same styling/layout from Atom's contextmenu. Have to find out where they defined that. |
Maybe native select box cannot display font icons properly 😢 OSX 10.10. JS Bin |
👍 for toggle buttons associated to toggle actions ! |
@MaximeWillinger commented on 28 mei 2015 11:12 CEST:
Reply from cakecatz/flex-toolbar#19 @jerone on 22 mei 2015 11:02 CEST:
It is possible to fetch every command (https://github.com/atom/notifications/blob/ea5aaf3a8329ce53f1c9281ac3a1b7c3d8cf8909/lib/command-logger.coffee), but it's not preferred and could significantly impact the performance of all of Atom (source). I did a quick test and it logged already a lot of redundant events while in idle state: atom.commands.onWillDispatch(function(event){console.log(arguments);}) |
The package which adds the button should take care of updating its state i.e.:
If there's one package adding buttons to another one (like in case of |
I would say that the best approach would be to create PR for package you want to control with toolbar support (in this case |
Have you given up on this? |
Custom buttons are on the backlog, but to quote myself from #79 (comment):
|
I'm reopening this issue as it's still something that's on the roadmap for the future, immediately after #49 |
Ahh, sorry. I've just cleaned up issues which opened by myself. |
Please add support for select, like this:
![2015-05-24 22-38-39 variables less - rent - projects nkt rent](https://cloud.githubusercontent.com/assets/3505878/7789391/6eae9296-0267-11e5-8e2c-056532a54c94.png)
The text was updated successfully, but these errors were encountered: