Decouple Setting property by using it via add_loadie() method

sudar · Sep 12, 2017 · 70fb994 · 70fb994
1 parent f4fb219
commit 70fb994
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/include/Core/EmailLog.php b/include/Core/EmailLog.php
@@ -64,14 +64,6 @@ class EmailLog {
 	 */
 	public $table_manager;
 
-	/**
-	 * Email Log Plugins Setting.
-	 *
-	 * @since 2.1.0
-	 * @var \EmailLog\Core\UI\Setting\Setting
-	 */
-	public $setting;
-
 	/**
 	 * Add-on Licenser.
 	 *

diff --git a/load-email-log.php b/load-email-log.php
@@ -37,7 +37,6 @@ function load_email_log( $plugin_file ) {
 	$loader->register();
 
 	$email_log = new \EmailLog\Core\EmailLog( $plugin_file, $loader, new \EmailLog\Core\DB\TableManager() );
-	$email_log->setting = new EmailLog\Core\UI\Setting\EmailLogSetting();
 
 	$email_log->set_licenser( new \EmailLog\Addon\License\Licenser() );
 
@@ -48,6 +47,7 @@ function load_email_log( $plugin_file ) {
 	$email_log->add_loadie( new \EmailLog\Core\Request\NonceChecker() );
 	$email_log->add_loadie( new \EmailLog\Core\Request\LogListAction() );
 	$email_log->add_loadie( new \EmailLog\Core\Request\OverridePluginAPI() );
+	$email_log->add_loadie( new EmailLog\Core\UI\Setting\EmailLogSetting() );
 
 	// `register_activation_hook` can't be called from inside any hook.
 	register_activation_hook( $plugin_file, array( $email_log->table_manager, 'on_activate' ) );