Markdown links should be external

sudara · Feb 17, 2016 · fff7b20 · fff7b20
1 parent 08553d3
commit fff7b20
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/greenfield/app/assets/javascripts/greenfield/posts.js b/greenfield/app/assets/javascripts/greenfield/posts.js
@@ -2,6 +2,4 @@
 $(document).ready(function(){
   // resizable textarea for edit page
   $('.edit-post-content textarea').autosize();  
-
-  $(".post-content a").attr("target","_blank");
 });
diff --git a/greenfield/app/markdown/greenfield/markdown.rb b/greenfield/app/markdown/greenfield/markdown.rb
@@ -30,9 +30,10 @@ def self.invalid_embeds(post)
     end
 
     def self.render(text)
-      renderer = Redcarpet::Markdown.new(new(:hard_wrap => true),
-                      :autolink => true, :no_intraemphasis => true,
-                      :fenced_code_blocks => true, :tables => true)
+      html_render = new(:hard_wrap => true, link_attributes: { target: '_blank' })
+      renderer = Redcarpet::Markdown.new(html_render,
+                                         :autolink => true, :no_intraemphasis => true,
+                                         :fenced_code_blocks => true, :tables => true)
       Redcarpet::Render::SmartyPants.render(renderer.render(text)).html_safe
     end