Update RSpec #108
Merged
Update RSpec #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This conversion is done by Transpec 3.0.7 with the following command:
transpec --force --convert stub_with_hash --convert example_group --explicit-spec-type
* 169 conversions
from: obj.should
to: expect(obj).to
* 55 conversions
from: == expected
to: eq(expected)
* 44 conversions
from: obj.should_not
to: expect(obj).not_to
* 24 conversions
from: describe 'something' { }
to: RSpec.describe 'something' { }
* 14 conversions
from: describe 'some controller' { }
to: describe 'some controller', :type => :controller { }
* 9 conversions
from: describe 'some model' { }
to: describe 'some model', :type => :model { }
* 8 conversions
from: obj.stub(:message)
to: allow(obj).to receive(:message)
* 4 conversions
from: be_true
to: be_truthy
* 4 conversions
from: expect(obj).to have_at_least(n).errors_on(...)
to: expect(obj.errors_on(...).size).to be >= n
* 2 conversions
from: be_false
to: be_falsey
* 2 conversions
from: lambda { }.should
to: expect { }.to
* 2 additions
of: RSpec.configure { |c| c.expose_dsl_globally = false }
* 1 conversion
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
mikeastock
force-pushed
the
update_rspec
branch
from
e160aa2
to
69f32bc
Compare
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades RSpec from 2 to 3.