Prevent the copy event from bubbling up to body #76
Conversation
|
I didn't know how to run the tests ( |
… from bubbling up Fixes firefox-devtools#1903 This is contributed to upstream in sudodoki/copy-to-clipboard#76.
… from bubbling up Fixes firefox-devtools#1903 This is contributed to upstream in sudodoki/copy-to-clipboard#76.
|
Thanks! Pulled via ad759b0 |
… from bubbling up Fixes firefox-devtools#1903 This is contributed to upstream in sudodoki/copy-to-clipboard#76.
|
Wonder whether #46 (comment) workaround will work after this (although it performs copying by that code snippet already) 🤔 |
|
ah yes indeed :/ |
|
Maybe we can add this workaround right in the copy event handler, what do you think? |
|
Another possibility is to set a white background to the span. Then the text would have a white background instead of a grey background. Still not perfect but better. |
|
Actually their workaround doesn't seem to work at all anyway. I'd suggest to just put a background to white. |
|
Ah yes it works, I had a bad state in my gdocs. Let me do a quick PR :) |
Fixes #75