Manifest knows about providers #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -412,3 +420,13 @@ def generate_files_under(self, path): | |||
| yield child | |||
| else: | |||
| frontier.append(child) | |||
|
|
|||
| def set_providers(self, providers): | |||
There was a problem hiding this comment.
This shouldn't be too hard to test, let's do it.
|
What else is going on with providers here? |
|
Just some renaming and pretty printing in preparation for the next 2 prs that we discussed. |
| @@ -111,3 +110,28 @@ def expose_to_client(self): | |||
| Whether this provider should be exposed in user interfaces | |||
| """ | |||
| return False | |||
|
|
|||
| @staticmethod | |||
| def type(): | |||
There was a problem hiding this comment.
I might call this something else, type sounds like it should be a python feature
There was a problem hiding this comment.
kind_of_provider seems verbose.
Since it's a class method, I think it's fine.
unless you have a suggestion?
|
Did a first pass |
|
@DoronShapiro done, take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DoronShapiro merge when you can