-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest knows about providers #46
Conversation
@@ -412,3 +420,13 @@ def generate_files_under(self, path): | |||
yield child | |||
else: | |||
frontier.append(child) | |||
|
|||
def set_providers(self, providers): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be too hard to test, let's do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
What else is going on with providers here? |
Just some renaming and pretty printing in preparation for the next 2 prs that we discussed. |
@@ -111,3 +110,28 @@ def expose_to_client(self): | |||
Whether this provider should be exposed in user interfaces | |||
""" | |||
return False | |||
|
|||
@staticmethod | |||
def type(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might call this something else, type sounds like it should be a python feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kind_of_provider seems verbose.
Since it's a class method, I think it's fine.
unless you have a suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name? provider_name?
Did a first pass |
@DoronShapiro done, take a look? |
@DoronShapiro merge when you can