Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request location permission when location permission is denied #37

Merged
merged 6 commits into from
Sep 4, 2022

Conversation

lqchuong
Copy link
Contributor

request location permission when location permission is denied

Copy link
Owner

@suesitran suesitran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a few comments. And 1 questions: where are the test?

lib/bloc/location/location_bloc.dart Outdated Show resolved Hide resolved
lib/bloc/location/location_bloc.dart Outdated Show resolved Hide resolved
lib/bloc/location/location_bloc.dart Outdated Show resolved Hide resolved
lib/features/home/home_screen.dart Outdated Show resolved Hide resolved
lib/utils/dialogs/dialog.dart Outdated Show resolved Hide resolved
lib/utils/dialogs/dialog.dart Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@suesitran suesitran added this to the MVP milestone Aug 27, 2022
@suesitran suesitran linked an issue Aug 27, 2022 that may be closed by this pull request
- remove Boolean to keep track if you have showed permission request dialog previously.
- move dialog to packages/nartus_ui_package/, create a new directory and name it 'dialog'
- modify dialog widget, add parrams to it
- remove shared_preferences package and internet_connection_checker package
- fix alert dialog
@lqchuong lqchuong force-pushed the koc/request-location-permission branch from 6b023cc to 146eaea Compare August 29, 2022 03:04
lib/bloc/location/location_bloc.dart Show resolved Hide resolved
lib/bloc/location/location_bloc.dart Outdated Show resolved Hide resolved
lib/bloc/location/location_event.dart Outdated Show resolved Hide resolved
lib/bloc/location/location_state.dart Outdated Show resolved Hide resolved
lib/bloc/location/location_state.dart Outdated Show resolved Hide resolved
lib/features/home/home_screen.dart Show resolved Hide resolved
lib/features/home/home_screen.dart Outdated Show resolved Hide resolved
lib/features/home/home_screen.dart Outdated Show resolved Hide resolved
@suesitran suesitran merged commit 1fb01f3 into suesitran:dev Sep 4, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

App first launch When location permission is denied
3 participants