-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request location permission when location permission is denied #37
Merged
suesitran
merged 6 commits into
suesitran:dev
from
lqchuong:koc/request-location-permission
Sep 4, 2022
Merged
request location permission when location permission is denied #37
suesitran
merged 6 commits into
suesitran:dev
from
lqchuong:koc/request-location-permission
Sep 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suesitran
reviewed
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added a few comments. And 1 questions: where are the test?
- remove Boolean to keep track if you have showed permission request dialog previously. - move dialog to packages/nartus_ui_package/, create a new directory and name it 'dialog' - modify dialog widget, add parrams to it - remove shared_preferences package and internet_connection_checker package
- fix alert dialog
lqchuong
force-pushed
the
koc/request-location-permission
branch
from
August 29, 2022 03:04
6b023cc
to
146eaea
Compare
suesitran
reviewed
Aug 29, 2022
- add enum PermissionStatusDiary
suesitran
approved these changes
Sep 4, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request location permission when location permission is denied