Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: yespower: do not use abort() with cache PoW #61

Merged
merged 10 commits into from
Feb 9, 2020
Merged

fix: yespower: do not use abort() with cache PoW #61

merged 10 commits into from
Feb 9, 2020

Conversation

decryp2kanon
Copy link
Contributor

@decryp2kanon decryp2kanon commented Feb 8, 2020 •
edited
Loading

cryptozeny
cryptozeny reviewed Feb 8, 2020
View reviewed changes
src/primitives/block.cpp Outdated Show resolved Hide resolved
@decryp2kanon
fix: (const uint8_t *) in yespower_tls
7ea15ba 
```
int yespower_tls(const uint8_t *src, size_t srclen,
    const yespower_params_t *params, yespower_binary_t *dst)
```
@decryp2kanon decryp2kanon changed the title yespower exit(1): do not use abort() [WIP] yespower exit(1): do not use abort() Feb 9, 2020
cryptozeny
cryptozeny requested changes Feb 9, 2020
View reviewed changes
src/primitives/block.cpp Show resolved Hide resolved
@decryp2kanon
Copy link
Contributor Author

solo mining on testnet is fine.
https://1explorer-testnet.cryptozeny.com/tx/adda5ba73f889500758094cf71694c32c7f64361562088169216d351fc5ef071

cryptozeny
cryptozeny approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@cryptozeny cryptozeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 071a57f

@decryp2kanon decryp2kanon changed the title [WIP] yespower exit(1): do not use abort() Sugarchain: refactor: yespower: do not use abort() with cache PoW Feb 9, 2020
@decryp2kanon decryp2kanon changed the title Sugarchain: refactor: yespower: do not use abort() with cache PoW refactor: yespower: do not use abort() with cache PoW Feb 9, 2020
@volbil
Copy link
Member

volbil commented Feb 9, 2020

Looking good ACK

@decryp2kanon
Copy link
Contributor Author

decryp2kanon commented Feb 9, 2020 •
edited
Loading

-reindex-chainstate took 5 hrs
-reindex took 10 hrs
no problem found.

@decryp2kanon
Copy link
Contributor Author

log

x block = 3a5580ada582ca819f8f4cc8a9eba73507c5c2322d8659c36183dc3d1e336b71 PoW = 00000098179aa1d2df06a7c98be2f9cfb32cc0925690a1d26e3b38d6b76f1073
x block = 3a5580ada582ca819f8f4cc8a9eba73507c5c2322d8659c36183dc3d1e336b71 PoW = 00000098179aa1d2df06a7c98be2f9cfb32cc0925690a1d26e3b38d6b76f1073
x block = f1436fe38845e2e28b8dc2228b86d9cf88a8ceb66f8f7c5aad4226e3279b4472 PoW = 000000ef8fb2cc233edd41887c980cca76b9e2181bff3499fa563b4e2be7a93c
x block = f1436fe38845e2e28b8dc2228b86d9cf88a8ceb66f8f7c5aad4226e3279b4472 PoW = 000000ef8fb2cc233edd41887c980cca76b9e2181bff3499fa563b4e2be7a93c
x block = 6747149bfd39ed370bf02ce7bc83c63b593d3a76bed4bab0b34d31f5dad80a4a PoW = 00000057f9f39892220827a87f5297c75d5b5d77454c2104cf25756e8d2af6e6
x block = 6747149bfd39ed370bf02ce7bc83c63b593d3a76bed4bab0b34d31f5dad80a4a PoW = 00000057f9f39892220827a87f5297c75d5b5d77454c2104cf25756e8d2af6e6
x block = 1ec76d0b6f55ada3f61f7ae915c2fac41d8f58f8104c62c7e0eafb7a487d72ee PoW = 000000bbd38c69e72e32db51654ca57164b8450956108674a20da589cf764b8d
x block = 1ec76d0b6f55ada3f61f7ae915c2fac41d8f58f8104c62c7e0eafb7a487d72ee PoW = 000000bbd38c69e72e32db51654ca57164b8450956108674a20da589cf764b8d

debug

2020-02-09 09:38:50 UpdateTip: new best=3a5580ada582ca819f8f4cc8a9eba73507c5c2322d8659c36183dc3d1e336b71 height=2925365 version=0x20000000 log2_work=44.056938 tx=3127481 date='2020-02-09 09:38:50' progress=1.000000 cache=278.6MiB(1729334txo)
2020-02-09 09:39:00 UpdateTip: new best=f1436fe38845e2e28b8dc2228b86d9cf88a8ceb66f8f7c5aad4226e3279b4472 height=2925366 version=0x20000000 log2_work=44.056939 tx=3127482 date='2020-02-09 09:38:50' progress=0.999999 cache=278.6MiB(1729336txo)
2020-02-09 09:39:01 UpdateTip: new best=6747149bfd39ed370bf02ce7bc83c63b593d3a76bed4bab0b34d31f5dad80a4a height=2925367 version=0x20000000 log2_work=44.05694 tx=3127483 date='2020-02-09 09:39:00' progress=1.000000 cache=278.6MiB(1729338txo)
2020-02-09 09:39:02 UpdateTip: new best=1ec76d0b6f55ada3f61f7ae915c2fac41d8f58f8104c62c7e0eafb7a487d72ee height=2925368 version=0x20000000 log2_work=44.056941 tx=3127484 date='2020-02-09 09:39:01' progress=1.000000 cache=278.6MiB(1729340txo)

@decryp2kanon decryp2kanon changed the title refactor: yespower: do not use abort() with cache PoW fix: yespower: do not use abort() with cache PoW Feb 9, 2020
@decryp2kanon decryp2kanon merged commit e59bb1c into master-v0.16.3 Feb 9, 2020
@decryp2kanon decryp2kanon deleted the feature_yespower_exit branch February 9, 2020 09:42
@decryp2kanon decryp2kanon mentioned this pull request Feb 9, 2020
Closed
@decryp2kanon
Copy link
Contributor Author

#61

@decryp2kanon decryp2kanon mentioned this pull request Feb 9, 2020
Closed
@decryp2kanon
Copy link
Contributor Author

cryptozeny/sugarchain-v0.16.3#120

decryp2kanon added a commit that referenced this pull request Mar 2, 2020
@decryp2kanon
fix: yespower: do not use abort() with cache PoW (#61)
4bea138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptozeny cryptozeny cryptozeny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@decryp2kanon @volbil @cryptozeny