Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Settings Part 5 Backup #60

Closed
wants to merge 15 commits into from
Closed

Conversation

decryp2kanon
Copy link
Contributor

@decryp2kanon decryp2kanon commented Oct 31, 2020

REF

TODO

UI

  • Splash Screen

    • src/init.cpp // LicenseInfo
    • src/qt/splashscreen.cpp
    • src/util.cpp remove
      image
  • Icon

    • share/pixmaps/bitcoin.ico
    • share/pixmaps/bitcoin128.png
    • share/pixmaps/bitcoin128.xpm
    • share/pixmaps/bitcoin16.png
    • share/pixmaps/bitcoin16.xpm
    • share/pixmaps/bitcoin256.png
    • share/pixmaps/bitcoin256.xpm
    • share/pixmaps/bitcoin32.png
    • share/pixmaps/bitcoin32.xpm
    • share/pixmaps/bitcoin64.png
    • share/pixmaps/bitcoin64.xpm
    • share/pixmaps/nsis-header.bmp
    • share/pixmaps/nsis-wizard.bmp
    • src/qt/res/icons/about.png
    • src/qt/res/icons/bitcoin.icns
    • src/qt/res/icons/bitcoin.ico
    • src/qt/res/icons/bitcoin.png
    • src/qt/res/icons/bitcoin.png
    • src/qt/res/icons/bitcoin_testnet.ico
  • Release Notes

    • doc/release-notes.md >> new one

SKIP

IBD

  • IBD: do not print this connection log during IBD Potential, connect() to %s failed
    • src/net_processing.cpp
    • src/netbase.cpp
  • Flying during IDB consensusParams.nPowTargetSpacing * 120
    • src/net_processing.cpp

YESPOWER

  • YespowerSugar 🤔
    • src/bench/checkblock.cpp

NETWORK

  • Bootstrap
    • contrib/linearize/README.md
    • contrib/linearize/example-linearize.cfg
    • contrib/linearize/linearize-data.py
    • contrib/linearize/linearize.cfg

UI

  • Delaying Updating Balance (workaround)
    • src/qt/walletmodel.cpp

FEATURE

  • -prunedebuglogfile
    • src/util.cpp bool fPruneDebugLog = false;
    • src/util.h

- Policy: No unnecessary changes on comments or words
- Disabled functional tests against no previous releases
  * feature_backwards_compatibility.py
  * wallet_upgradewallet.py
  * mempool_compatibility.py
- CI:
  * Travis
  * Cirrus
  * Gitian
- Ports:
  * Main: 8333/8332 -> 34230/34229
  * Testnet: 18333/18332 -> 44230/44229
  * Regtest: 18444/18443 -> 45340/45339
  * Signet: 38333/38332 -> 54230/54229
- Fixed tests:
  * src/test/addrman_tests.cpp
  * test/functional/p2p_addr_relay.py
- CI:
  * Travis
  * Cirrus
  * Gitian
- Disallow fPowNoRetargeting on testnet
- Remove: Special difficulty rule for testnet
- Disabled Tests:
  * src/test/fuzz/pow.cpp
  * src/test/miner_tests.cpp
Reference:
- zcash: https://github.com/zcash/zcash/blob/4c90270469e32cbf3459ec2fd25d46a089bd5c58/src/pow.cpp
- bitcoin: https://github.com/bitcoin/bitcoin/blob/eb7daf4d600eeb631427c018a984a77a34aca66e/src/pow.cpp
- Add module: https://www.openwall.com/yespower/yespower-1.0.1.tar.gz
- Fix lint: regexp exclude prefix: src/crypto/yespower-1.0.1
Reference:
- sugarchain: sugarchain-project/sugarchain#22 by Volbil
- resistance:
  * ResistancePlatform/resistance-core@a73d694 by solardiz
  * ResistancePlatform/resistance-core@3c80dac
  * ResistancePlatform/resistance-core@20c7ba3...3c80dac
- util:
  * replace fprintf with tfm::format: bitcoin/bitcoin@fac03ec
  * function "bool ProcessNewBlock(...)" moved to "bool ChainstateManager::ProcessNewBlock(...)" in validation.cpp
  * use "m_blockman.m_block_index" rather than "mapBlockIndex" in validation.cpp
Disabled Tests:
- no fuzz on `00_setup_env_native_fuzz_with_valgrind`
- no unit tests, no functional tests on Arm64
- "--disable-shared" for yespower on Win64
- no extended, no previous releases on x86_64 Linux

Disabled Functional Tests (29) in `test/functional/test_runner.py`:

CI:
- Travis
  * remove YESPOWER_OPTION against conflict with MSAN_FLAGS
- Cirrus
- Gitian

Windows Build for all (yespower): use "--disable-shared", skip DLL in gitian
- Changes:
  * nPowTargetSpacing = 5
  * nSubsidy = 42.94967296
  * MAX_MONEY = 1073741824
  * nSubsidyHalvingInterval = 12500000
    - TODO: policy/feerate.cpp:16:34: runtime error: signed integer overflow: 107374182400000000 * 1000 cannot be represented in type 'long'
  * MAX_FUTURE_BLOCK_TIME = 60
  * DEFAULT_HTTP_WORKQUEUE=128
  * STALE_CHECK_INTERVAL = 5
  * EXTRA_PEER_CHECK_INTERVAL = 3
  * MINIMUM_CONNECT_TIME = 15
  * DEFAULT_MAX_TIME_ADJUSTMENT = 70
  * pchMessageStart

- Disabled Tests:
  * src/test/amount_tests.cpp
  * src/test/fuzz/fee_rate.cpp
  * src/test/fuzz/fees.cpp
  * src/test/fuzz/psbt.cpp
  * Many in test/functional/test_runner.py

- Fixed Tests:
  * src/test/pow_tests.cpp
  * src/test/timedata_tests.cpp
  * src/test/validation_tests.cpp
  * src/timedata.cpp
  * src/wallet/test/wallet_tests.cpp
  * test/functional/feature_loadblock.py
  * test/functional/test_framework/p2p.py
    - TODO: Signet MAGIC_BYTES
- Changes:
  * PUBKEY_ADDRESS
  * SCRIPT_ADDRESS
  * bech32_hrp

- Fixed Tests:
  * src/qt/test/uritests.cpp
  * src/qt/test/wallettests.cpp
  * src/test/key_tests.cpp
  * src/test/rpc_tests.cpp
  * src/test/util/wallet.cpp
  * src/test/util_tests.cpp
  * test/functional/test_framework/address.py
  * test/functional/test_framework/test_node.py

- Fixed Test Data:
  * src/test/data/key_io_invalid.json
  * src/test/data/key_io_valid.json
  * Many in test/util/data/

- Disabled Tests:
  * Many in test/functional/test_runner.py
- Changes:
  * nMinimumChainWork, defaultAssumeValid, chainTxData
  * m_assumed_blockchain_size, m_assumed_chain_state_size
  * vSeeds

- CI:
  * Travis: No unit tests on MSan
- Changes:
  * DEFAULT_FALLBACK_FEE
  * BIP16Exception
  * BIP34Height, BIP34Hash
  * BIP65Height
  * BIP66Height
  * CSVHeight
  * SegwitHeight
  * MinBIP9WarningHeight
  * nPowTargetTimespan
  * nRuleChangeActivationThreshold
  * nMinerConfirmationWindow

- Fixed Tests:
  * src/test/versionbits_tests.cpp (however not even broken)
@decryp2kanon decryp2kanon changed the title !Fix: During IBD, do not print "Potential stale tip detected..." [WIP] Settings Part 5 Oct 31, 2020
@decryp2kanon decryp2kanon changed the title [WIP] Settings Part 5 [WIP] Settings Part 5 Backup Nov 1, 2020
@decryp2kanon decryp2kanon deleted the settings_5th_201101 branch November 7, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant