-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #23, install Reports to help ProfM track student health #24
Fixes #23, install Reports to help ProfM track student health #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These reports look really nice! A couple of suggestions...
- The new API calls in Postman are in the Create Quotes category. We probably want them in their own category so people can find them.
- The new API calls don't have any tests associated with them.
- We probably want to update the doc to let people know these reports exist.
41d1dba
to
be17db5
Compare
@lschaefer-sugarcrm I've made updates. It should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two comments on the doc. The report functionality is great, so I'm marking this as approved. Not merging to allow for doc updates.
docs/StudentHealthTracking.md
Outdated
|
||
When doing battle against the forces of evil, it is possible that a coder is incapacitated by carpal tunnel syndrome or even killed in a freak hoverboard accident. Professor M needs to report on the cause of death of any coder who has died in order to prevent the same mistakes from happening again. | ||
When doing battle against the forces of evil, it is possible that a coder is incapacitated by carpal tunnel syndrome or even killed in a freak hoverboard accident. Professor M needs to keep track on the health of his students to make sure they are happy and productive and stay out of danger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: keep track of
docs/StudentHealthTracking.md
Outdated
@@ -21,7 +21,7 @@ A custom Vitals dropdown field (`vital_c`) was added to the Students module and | |||
|
|||
When `deceased` is selected, a new Death Information panel appears on the Record view and users are required to enter a Cause of Death (`cause_of_death_c`). | |||
|
|||
Professor M can then build reports based upon vital status and the common causes of death. | |||
Two reports in a dev instance and then exported via REST API. These reports are then added to the Prof M. data collection. These reports rely primarily on `vital_c` and `cause_of_death_c` fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence doesn't make sense to me: Two reports in a dev instance and then exported via REST API.
be17db5
to
af275f6
Compare
Adds a couple reports to the data import Postman collection.