Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUPP-875 Implementation of new endpoints: count & duplicateCheck #38

Merged
merged 3 commits into from
Nov 5, 2018
Merged

SUPP-875 Implementation of new endpoints: count & duplicateCheck #38

merged 3 commits into from
Nov 5, 2018

Conversation

dnlk17
Copy link

@dnlk17 dnlk17 commented Oct 12, 2018

providing 2 new endpoints:

  • /<module>/count GET (solves issue Add 'count' #36)
  • /<module>/duplicateCheck POST

also included:

  • examples

@dnlk17 dnlk17 mentioned this pull request Oct 12, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 88.757% when pulling 8ee0f9d on dnlk17:new_endpoints into 2d75cae on sugarcrm:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 88.757% when pulling 8ee0f9d on dnlk17:new_endpoints into 2d75cae on sugarcrm:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 88.757% when pulling 8ee0f9d on dnlk17:new_endpoints into 2d75cae on sugarcrm:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 88.757% when pulling 8ee0f9d on dnlk17:new_endpoints into 2d75cae on sugarcrm:master.

MichaelJ2324
MichaelJ2324 approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@MichaelJ2324 MichaelJ2324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@dnlk17
Copy link
Author

dnlk17 commented Nov 5, 2018

@geraldclark @MichaelJ2324
Could someone please continue this pull request? :)
Thank you!

@geraldclark geraldclark merged commit 84a934e into sugarcrm:master Nov 5, 2018
@geraldclark geraldclark changed the title Implementation of new endpoints: count & duplicateCheck SUPP-875 Implementation of new endpoints: count & duplicateCheck Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelJ2324 MichaelJ2324 MichaelJ2324 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dnlk17 @coveralls @MichaelJ2324 @geraldclark @dkarl-boc