Changed the background image of alphabets to dynamic alphabets #23
Conversation
- Before the activity toolbar was not visible and was overlayed by the activity in pygame version 2.4.0 - Now this issue is being resolved by changing how the canvas is made
- The alphabets of the ring were till now being placed by an image - This has been changed and now the alphabets are being placed by calculating the points according to the screensize - The new function in utils.py - generate_ellipse_points() is used in generating those points
|
@chimosky Thanks, Applied the requested changes |
|
For future messages, please leave a new line before your commit message body. |
|
Activity toolbar shows when I test master, the code at master does what's expected of it, setup the toolbar before setting the pygame canvas as the activity canvas. Do you see any errors in the logs when you test? |
|
I noticed that the activity toolbar is visible at pygame version edit : This happens on master and 414b3f fixes it Logs were clean 
|
|
Please work with the Pygame source code to find out what has changed, understand the impact of the change, and then make a plan for how to maintain activities so that they can support both versions of Pygame. |
|
This is what I see when I test master
Tested 5fd5535 and the dimensions are off;
|
|
You also syay you changed the background image to dynamic alphabets but your change shows only addition and no removal of the old way of doing things. |
Similar changes of countries-activity are applied here.
Please Review @chimosky @sourabhaa