Browse: Improve autocomplete list #4081 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the lists scrolleable (upto max 20 entries). Number of entries increased to 20. Can be scrolled through both up/down arrow keys and mouse scroller. Puts the URL below the Title, so more url text is visible now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes this defect -> https://bugs.sugarlabs.org/ticket/4081
With this PR ->
1- autocomplete list will now be able to display list of 20(max) entries which can be scrolled with both mouse pointer and Up/Down arrow keys.
2- URL is now placed below the Url title so that more text is visible.
3- The visible length of the list is of 5 entries so it won't also not superimpose over the OSK.
@samdroid-apps Please review it and let me know if any further modification are required. :)
