-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata | Add Screenshots #82
Conversation
Thanks. Reviewed to 27d2e1e. Please consider;
|
|
Thanks.
You made changes to a collabwrapper file; so you ought to be able to explain what changes you made. Make these changes first in the other repository.
As far as this activity is concerned, it is a Python module. See the other repository for what collabwrapper is. |
Made a PR - link - sugarlabs/collabwrapper#6 |
Merged However, your changes here to collabwrapper are different, please resolve. |
@quozl The difference in changes are just of whitespace. I can fix that as well but it's not that critical. Should I? |
Yes, I know they are whitespace changes, but you did make them here and did not make them there, so the files won't match, and there's a risk of future patches to collabwrapper not being applied easily here. You can either remove the whitespace changes here, or make the whitespace changes there. |
@quozl That's what I am trying to reason here, there are no problems left with |
Signed-off-by: James Cameron <quozl@laptop.org>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
An activity will often maintain a list of buddies. For a leader, it is easy to maintain the list, after sharing the activity, by receiving the buddy_joined and buddy_left signals. For a non-leader, it was not easy to maintain the list, after joining a shared activity, without calling underneath CollabWrapper into sugar3. When an activity has been joined, iterate through the buddies and emit buddy_joined for each. Also rewrite documentation accordingly, and simplify. Taken from collabwrapper:84be1509d7e289829e7e542c6bd33b3997e9036
Looking deeper;
|
@quozl It's very odd, indeed. If the activity has a maintainer, maybe he/she can work towards improving it. |
I did, pushed to your branch, then merged. You're welcome to review. |
Updated following parameters
url
,license
,tags
Corrected Address in LGPL and GPLv2 licenses.
Added screenshots.