Upstreaming v21.1 #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display was being updated twice a second, because the timeout was scheduled twice, because the active property was set to True by the toolkit twice. The toolkit avoids this by not processing a second active True. Ignore property changes that have no effect.
On OLPC XO-4 laptop, opening the audio device causes a click, and this makes the ticking clock noisy. Existing logic was to play a 200 ms sound file every second, wait for end of stream, rewind, and play again. This closed and opened the audio device. Now, rewind and play a 1200 ms sound file and pause it after 450 ms. End of stream is never reached. This keeps the audio device open.
On OLPC XO-1, if the ticking clock is already enabled, a traceback
occurs;
Traceback (most recent call last):
File "/home/olpc/Activities/Clock.activity/clock.py", line 467, in _ticking_toggled_cb
if self._pathetic:
AttributeError: 'ClockActivity' object has no attribute '_pathetic'
Caused by toggling the button before the hardware has been identified.
Move the identification of hardware higher up in the initialisation.
On OLPC XO-1 rewinding the GStreamer pipeline yields a random volume level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in the Python 2 branch are potentially useful for the Python 3 branch.