linting/typecheck logs, HMR, upgrade dependencies [week-2+3] - #197
Merged
Conversation
* flexibility for default subdirectory deployment (domain.com/dir) * another build command allows for root deployment (subd.domain.com) Signed-off-by: Anik Das <anikdas0811@gmail.com>
* used eslint-webpack-plugin * logs error to terminal and an overlay during development
* sketch.clear() takes 4 args -> r, g, b, a -> added them * svg imports needed to be declared for typescript to identify their types, added declaration to react-app-env.d.ts
Signed-off-by: Anik Das <anikdas0811@gmail.com>
meganindya
force-pushed
the
sadn1ck/week-3
branch
from
September 8, 2022 16:23
1937629 to
e8fef57
Compare
meganindya
approved these changes
Sep 8, 2022
meganindya
added a commit
that referenced
this pull request
Sep 8, 2022
linting/typecheck logs, HMR, upgrade dependencies [week-2+3]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with HMR which leads to full reload happening everytime. I believe that is due to the components manually inserted not being in the main component tree. Still having a look at this.
cc @meganindya @ksraj123