Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing a block near to a closed block will attach to it #1649

Closed
sarthakagr104 opened this issue Dec 13, 2018 · 4 comments
Closed

Bringing a block near to a closed block will attach to it #1649

sarthakagr104 opened this issue Dec 13, 2018 · 4 comments
Labels
Issue-Duplicate Please include link to duplicate issue.

Comments

@sarthakagr104
Copy link
Contributor

I found an issue in music-blocks
Tested on : https://play.musicblocks.net/ , https://musicblocks.sugarlabs.org/
OS : MacOs Mojave [10.14.0]
Browser : Google Chrome

When you get a block and place it near minimised block, the block will be the part of that whole block
Here is a video explaining it :
https://youtu.be/zBbm2UoRz4k

@walterbender
Copy link
Member

I think this is a duplicate of #1634 which has been fixed on the master branch. Can you please test to see if you experience this issue on master?

@walterbender walterbender added the Issue-Duplicate Please include link to duplicate issue. label Dec 13, 2018
@walterbender
Copy link
Member

The View More and View Less strings are not marked for translation, which is probably the root cause of the problem.

Should be

toggleText('view-more-chips',_('View More'), _('View Fewer'));

@aust-n
Copy link
Contributor

aust-n commented Dec 13, 2018

@walterbender I am puzzled as to how the "View More" and "View Less" strings are related to this issue.
I have assumed it's a comment regarding #1648 and moved it there :P

@walterbender
Copy link
Member

I think this is fixed. Please reopen if it still occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Duplicate Please include link to duplicate issue.
Projects
None yet
Development

No branches or pull requests

3 participants