Add, Divide, Delete menu for note durations

[sparsh0204]

Added pie menu containing add, delete and divide function for note duration.

[walterbender]

I am a bit confused by the UX. I cannot seem to change the duration, which is what I thought the number would do. I can add notes.

[sparsh0204]

I thought that we only want a way to add, divide and delete. Is something like this fine. We can use outer wheel to edit duration value.

[walterbender]

The principal goal is to change the note duration. Essentially the same functionality as in the Phrase Maker.

[walterbender]

I guess I am misremembering, but I though at one point, you could edit the note duration more like the way like this:

[sparsh0204]

No it was like what I made here(musical keyboard). If its fine we can replace it by some common values like 1/8, 1/4,1,etc.

[walterbender]

Sure. Some common values would work. Maybe?
1/16 1/8 1/4 1/3 3/8 1/2 5/8 2/3 3/4 7/8 1/1

[walterbender]

I think this is much easier to use. But for some reason, I could not get 1/16 to work.

[sparsh0204]

I didn't see that. I thought that we decide 1/8 will be the smallest division

[walterbender]

I'm fine with getting rid of 1/16 (but it appears in the menu and doesn't work)

[walterbender]

Maybe you can do the same thing for phrasemaker?

[pikurasa]

I would have preferred something more like what we have for note value for specifying note values. This puts duples with tuples (1/3).

[pikurasa]

It also mixes in ties (5/8) with dotted notes (3/8).

[pikurasa]

(Now that I test at a computer) I see that 2/3 and 1/3 do not produce the intended note value.

When you click 1/3, you get 3/8, and when you click 2/3 you get 5/8, which are not the same.

I think it would be best if outside of the divide/delete/add inner section of the pie menu, the outer pie menu were the same as the note block, 2, 3, 5, and 7 (for category of note value denominator) and their respective submenus.

Also, I think 1/16 should be the smallest division. 1/16 is common.

[sparsh0204]

@pikurasa The thing is that the widget automatically converts the duration to the nearest 1/8 note so 1/3 gets converted into 3/8. I will try and find a way around it so that values like 1/3 and 2/3 can be added. There will be a problem with the outer block being 2,3,5 and then opening their submenus as the pie menu will become large(exitwheel - add/divide option wheel - number of notes - outer wheel - outer wheel submenu). I will make 1/16 the smallest but should the notes round off to nearest 1/8 or 1/16.

[pikurasa]

If we do it this way, we need to think,more about the order such that triplets (1/3, 2/3) are separate from duples. Musically, the two are very different.

[pikurasa]

Thinking about it more:

We can divide notes to get tuplets, and we can merge notes to get dots and ties.

I think we only need the following options:
1/1,1/2,1/4,1/8, and 1/16.

The widget should warn,the user that it is not taking any input shorter than 1/16.

[sparsh0204]

I am a bit confused here. So what I need to change now is make 1/16 the smallest and round of notes to the nearest 1/16. Also edit duration menu should have options(1/1,1/2,1/4,1/8, and 1/16). And there should be a way to have 2/3 or 1/3 duration. Am I right or is something missing or wrong.

[pikurasa]

You do not need any new way to "have 2/3 or 1/3 duration". We already have a method--"divide".

[pikurasa]

Otherwise, what you say is correct.

[pikurasa]

The thing is that the widget automatically converts the duration to the nearest 1/8 note so 1/3 gets converted into 3/8.

If this is for transcription, then that makes perfect sense. However, I would not want to limit the editing to 1/8 note (in the resultant matrix/graph).

[pikurasa]

@sparsh0204 Please let me know what your understanding is, so that we can make sure we are on the same page. Thanks!

[sparsh0204]

@pikurasa I think we are on the same page now but if I will have any doubts I will contact you.

[pikurasa]

Basically, my proposed improvement to the pie menu is to only have 1/1,1/2,1/4,1/8, and 1/16 in pie menu as everything else can be created by another method. (And because mixing these various types of notes is highly unusual in music.)

[sparsh0204]

@pikurasa I think that #1838 covers the cases. But 2/3 and 1/3 still can't be achieved in current situation(notes are rounded off to nearest 1/8 or 1/16). I can work on making it work if you want or is it fine.