Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have made changes to this file most of which is
var
tolet
. I also tested the changes to make sure nothing breaks. I had to leave some declarations withvar
because of their global use.I also noticed something I think is a mistake on line
3289
of the current version and line3272
of this commit. The variableselectedNote
is declared and assigned a value but never used. I think this variable is meant to beselectednote
. Because if you look in the current version, within the same scope on line3306
, there is a passing of an argumentselectednote
to functionpiemenuPitches()
which I believe should be the value defined forselecteNote
. If you could please look at it.There were also place I moved the variable declaration to a more global location within the same scope though, to allow the use of
let
.