Adding classes

[kushal-khare-official]

Issue #2629
Port to class definition and more:

• block.js
• blockfactory.js
• blocks.js
• boundary.js
• languagebox.js
• palette.js
• pastebox.js
• pluginsviewer.js
• protoblocks.js
• saveInterface.js
• toolbar.js
• trash.js
• widgets/help.js
• widgets/meterwidget.js
• widgets/modewidget.js
• widgets/musickeyboard.js
• widgets/oscilliscope.js
• widgets/phrasemaker.js (rename class from PitchTimeMatrix to PhraseMaker)
• widgets/pitchdrummatrix.js
• widgets/pitchslider.js
• widgets/pitchstaircase.js
• widgets/rhythmruler.js
• widgets/statistics.js
• widgets/status.js
• widgets/temperament.js
• widgets/tempo.js
• widgets/timbre.js
• widgets/widgetWindows.js

Reviewers:

@meganindya

[meganindya]

Three things:

• do a rebase every time you start with (don't want previous commits reapprearing)
• (for this one) one file at a time please
• mark PR as draft if incomplete

[kushal-khare-official]

@meganindya @walterbender I was editing pluginsviwer.js. Could you provide a plugin for testing purposes.

[meganindya]

Three things:

• do a rebase every time you start with (don't want previous commits reappearing)
• (for this one) one file at a time please
• mark PR as draft if incomplete

11k+ lines will be a mammoth task to review.

Please follow the following:

1. stash any uncommitted changes
2. rebase you master to current master of sugarlabs/musicblocks
3. create a new branch
4. cherry pick your commits on one file
5. create a new PR from that branch
6. wait for review
7. make any suggested changes if at all
8. go back to 2 until all the files have been dealt with one at a time
9. pop stash and practice the same thereafter

[meganindya]

it's "editing" btw

[walterbender]

Step 4.5: Test your changes. (There is no point in making a PR from broken code.)

…

On Sat, Nov 28, 2020 at 8:17 AM Anindya Kundu ***@***.***> wrote: Three things: - do a rebase every time you start with (don't want previous commits reappearing) - (for this one) one file at a time please - mark PR as draft if incomplete 11k+ lines will be a mammoth task to review. Please follow the following: 1. stash any uncommitted changes 2. rebase you master to current master of sugarlabs/musicblocks 3. create a new branch 4. cherry pick your commits on one file 5. create a new PR from that branch 6. wait for review 7. make any suggested changes if at all 8. go back to 2 until all the files have been dealt with one at a time 9. pop stash and practice the same thereafter — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2633 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6PXYLB5GJ5NW35YWMXCO3SSD2AJANCNFSM4UFUTO4Q> .

-- Walter Bender Sugar Labs http://www.sugarlabs.org <http://www.sugarlabs.org>

[kushal-khare-official]

11k+ lines will be a mammoth task to review.

@meganindya though its says 11k+ lines, its is just because creating a class indents the whole code by one tab space. It cant be dodged.

[kushal-khare-official]

@meganindya To simplify the reviewing process, I was thinking maybe I should reduce this one tab space added to the all the files. Though the files will not be correctly indented, it will simplify the review process and then we can add this tab space later when we lint all the files

[meganindya]

You are literally spamming. I told you to break this into multiple PRs and open one at a time, not all 25 at once.

Please close all your PRs except the first one (not this one, the one after this). We can reopen them one by one as required. In fact, close this one too, this is now redundant.

It's getting nearly impossible for us to follow anything. This sort of change maybe simple, but due to the scattered nature, needs to be verified thoroughly.

If you do not follow, we might have no other way out other than taking down your access.

[kushal-khare-official]

You are literally spamming. I told you to break this into multiple PRs and open one at a time, not all 25 at once.

Sorry for that. I have closed rest of the PRs.