Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding classes to toolbar.js #2648

Merged
merged 3 commits into from
Jan 14, 2021
Merged

adding classes to toolbar.js #2648

merged 3 commits into from
Jan 14, 2021

Conversation

kushal-khare-official
Copy link
Contributor

part of issue #2629

meganindya
meganindya requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Uncaught ReferenceError: y is not defined
    at SaveInterface._printBlockSVG [as printBlockSVG] (:3000/js/activity.js:760)
    at SaveInterface.saveBlockArtwork (:3000/js/SaveInterface.js:209)
    at HTMLAnchorElement.saveArtworkSVG.onclick (:3000/js/toolbar.js:239)

meganindya
meganindya requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

activity.js:4713 Uncaught ReferenceError: StatsWindow is not defined
    at activity.js:4713
    at HTMLAnchorElement.displayStatsIcon.onclick (toolbar.js:355)
Uncaught TypeError: Cannot read property 'visible' of undefined
    at deletePlugin (activity.js:1486)
    at HTMLAnchorElement.delPluginIcon.onclick (toolbar.js:363)

@kushal-khare-official
Copy link
Contributor Author

@meganindya I resolved the first error but couldn't resolve the second one.
The value of palettes.buttons["myblocks"] is not set in any of the files. Maybe replacing it with palettes.dict["myblocks"] may work, but I am not sure.

@meganindya
Copy link
Member

Why is this PR so massive?

@kushal-khare-official
Copy link
Contributor Author

Why is this PR so massive?

I did something wrong while doing a rebase.

meganindya
meganindya approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@meganindya meganindya merged commit 901cc35 into sugarlabs:master Jan 14, 2021
@daksh4469
Copy link
Member

I have a small change to make in js/toolbar.js. Should I go ahead with it and make a pull request?

@daksh4469 daksh4469 mentioned this pull request Jan 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganindya meganindya meganindya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kushal-khare-official @meganindya @daksh4469