Fixes visual bug specific to status block #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed visual bug
|
@Hrishi1999 Thanks for fixing the visual bugs. |
|
@pikurasa Welcome :) |
walterbender
pushed a commit
that referenced
this pull request
Mar 13, 2017
* Update basicblocks.js Fixed visual bug * Update basicblocks.js
walterbender
pushed a commit
that referenced
this pull request
Mar 17, 2017
…on hover (#645) * Bugfix As in title * Made more changes As in title * remove redundant code * use a heap to store fib numbers before playing * add clear button * small formating tweak * Fix - "Notes play out of time when tab is out of focus" (#501) * Added onBlur listener The music will stop if the tab is left * Stop button hidden when music stops As in title * Bugfix As in title * Made more changes As in title * add some comments * fixes #301 : remove element before creating it again * Fixed #495; made removal of the only start block impossible (#502) * Fixed #495; made removal of the only start block impossible * Changed error message when removing last start block * Rhythm timing (#503) * better interweaving of rulers * track offsets for each ruler individually * remove console spam * better handling of elapsedTimes and offsets to enable more consistent playback; disable dissecting while playing * Fixed #492; waitFor now gets connected with others (#504) * clean up comments, formatting * fixes #271 : wrong array index used in loop limit * Fixed #323; removed never used piece of code (#507) Standard debugging and code look-up shows the function is never called during normal usage. To be removed. * minor formatting tweaks * When an action block name is disconnected and then reconnected, we need to check for name collisions. This addresses one component of Issue #437. * add cleanup method -- we may need it * missing ; * cleanup * assume standard block size when bounds not available. Fixes #407 * migrate turtle palette enhancements * fixes 348 (#514) * Update index.html (#515) * Fixes 524 (#527) * new artwork for widget cells * use mouse artwork * use mouse artwork; fix issue with changing drum or pitch names between instances * fix i18n issues with drum and mode * turtle --> mouse * mouse --> cursor * Yertle -> Mozart * more turtle->mouse * don't rotate 90 degrees * updates to strings: raton * don't allow blank action name * remove console spam * use 1/note value * get rid of spaces around / * more robust conversion of note value to fraction * use HZ when displaying hertz * Fixes issue #516; repeat block shows undefined behaviour (#530) * Fixes issue #516 * Necessary changes made * Prepend MusicBlocks_ to share urls As in title * partial solution to 526: when an action name is removed from an action block, generate a default value * remove palette entry when deleting action * Prepend MusicBlocks_ to share urls (#534) As in title * Edited error in Guide (#536) * Delete tempo0.svg * replaced "seconds" with "minutes" * fix regression in silent note handling * more robust conversion of frequncy to pitch/octave/cents * remove some console spam * 'run=true' flag will now work for all projects An event is sent out to run the project once it is loaded. * renameDos too * avoid race condition when removing action prototypes from the Action palette * use hertz directly when available * fixes #537 by checking for cases where label name has not changed * fixes #487 ; added ratio expression to pitch staircase output * fixes #540 : regression in transposition of Hertz blocks * fix bug in identifying protoblock to remove from palette during delete * fixes problem with action palette updates on load * remove console spam * partial fix to yet another corner case discussed in #539 * more tweaks to address #537 * fix regression in action palette * put block name in palette above store in * fix regression in palette display due to action palette always refreshing * more progress re #537 * disconnect before searching for unique action names * check for note attributes, e.g, # and b, when doing i18n * fix bug in splitSolfege which introduced extra # * fixes #543 ; transpositions were not being properly applied in either the pitchtimematrix or pitchdrummatrix * Made small changes As per @pikurasa * Mistake Removed redundant console.log * fixes #545 ; check in PTM if note is solfege * Event listener removed when called As in title * fixes #547 ; also fixes an issue with intermitten failure of proto blocks to appear on the palette. * Issue #517; "To the power of" block added (#546) * Fixes #517 * Unnecessary space removed * clean up; move power block below sqrt * add example using new power block * some more 'musical' defaults for math blocks * use 1/4 for note value in tuplet * just in case an old-style tuplet2 block is encountered * catch plugin errors * remove console spam * updates for #509 tone oneof sqrt * add tuplet3 to list of expandable blocks * Set voice default added (#555) * Fix for "Fix for issue #494" (#561) * Small bugfixes Checks whether the function is being run the first time before playing the music. * standards-compliant now :) as in title * Changed some defaults; issue #509 (#554) * Changed some defaults * internationalisation done * new example of exponents * allow scaledegree to increase beyond the mode length by bumping ocatves * fix bug in insideNoteBlock * add support for neg scale degree * make consistent defaults: sol and G * fixes #577 a regression in the note attribute selector * add backward support to nameddoArg blocks * fix issue with conflict between named box name and macro name * remove comments from resolved issues * Some more defaults added (#583) * Fixed #508; rough workaround to get backspace working (#542) * cleanup * possibily fixes #522. clearing innerHTML of table between sessions * fixes #302 -- add undo to pitch staircase * fixes #584 : maintains undo order between rulers * clear button table between sessions * fixes #576 * Fixes #580 * Unnecesary space removed * Suggested changes made * re walterbender@8f394fc#commitcomment-20845416 * fix bug in neg. scale degree * refactor rhythmruler code (#590) * refactor rhythmruler code * increase the button icon size * use easier-to-decode names for ruler divs * add drag handle; fix broken input field * more dynamic sizing of the widget * clean up * make rulerDiv visible on init * don't add label when cell is too narrow * Comment changed (#591) * Improved trash (#589) * Improved trash * Update trash.js * Simple tuplet (#595) * add simple tuplet block * add vspcae * add simple tuplet artwork * explain the simple tuplet * add triplet; quintuplet; septuplet * Fixes #573; Articulation needs to be renamed (#592) * Fixes issue #573 * final guide updation * Name changed to set relative volume * better? * better arrow heads * Changed SVG files (#598) * add notes counter * typo * fixes #599 : reset all clocks on each init * add notes played block * use fraction format when showing notes-played status * use notes played as a default in the status block * use mixedfraction method when displaying block values; missing break * use fixed2 for some block values * emable simple tuplet block to be used inside a tuplet block * New tuplet (#597) * add new-style tuplet block with no vno 'number of notes' arg * update artwork, guide to use new tuplet block * better sizing/spacing * add internal support for a new block type needed for an 'argument flow' * use LCD to calculate tuplet value as per #562 * Changed name of crescendo block to "crescendo +/-" (#606) As in title * Renamed turtle palette to mouse palette (#607) As in title * example of an event-driven project * use set-heading instead of right; use 7 instead of 8 for maximum step * use fatter pen * use mode spacing * more tweaks to graphics * add labels to the pitch circle * add div that was somehow removed * fix problem with argflowclamp expansion * fix nasty race condition in action palette * fix typo in example * Hover added (#609) * formatting; no need for bold or larger as it messes with the table cell size * add note counter * turn off lilypond save after saving to lilypond * Fine-tuning done (#610) * formatting * fix problem with expanding argflow clamps on load * fixes #601 * fixes #575 paste button blinks when new stack is copied * only enable drag on the drag handle * remove listeners when not needed * remove console spam * refactor drag code to work in both Chrome and Firefox * restore cell contents if there is no drag * use same ... for nameddos as for the action block names * use unique name for ruler inner and outer divs * prm refactoring -- everything but tuplets is working * tuplets work again * tweak widget sizing * fix regression in chords * reorder intervals on palette * Augmented Intervals ,Fixes #565 (#614) * improvement to dragging: drop onto self * fix error in debug output * fix error is matrix export; fix problem in tuplet playback * refactoring of major interval * refactoring of minot interval * refactor perfect, augmented, diminished * Invert block : note to name (#617) * Default changed (#618) * rerun i18n scripts to updayte POT and PO files * update artwork for guide * note->name * second rhythm block in rhythm ruler was of the deprecated form * throw error when rhythm ruler imbalance is detected * catch error on dissect * note->name * enable new octave logic to invert and to frequency blocks * fixes 620 repeat in rhythemruler clamp * fixes #619 -- using mouse on start blocks in guide * missed a few * don't override -1, 0, 1 when calculating octave * don't force minimum octave to 1 * use name instead of note for consistency * fixes #579 -- invert return value, e.g. return 1/4 for a quarter note * fix bug causing infinite loop while searching for exandables * use mouse name block as default arg for mouse x and mouse y blocks * add images to separate cell in matrix * fix issue with sorting simple tuplets in matrix * fix regression in fill code * don't instance null names onto boxes palette * Fixes visual bug specific to status block (#628) * Update basicblocks.js Fixed visual bug * Update basicblocks.js * language file for Guarani * fixes #629 - regression in tuplet note value display * fixes #624 -- consider beat factor when calcualting note count * fix issue with null labels * reenable scaling of PTM * fixes regression in export matrix: missing row is added; missing row labels are added * fixes #630 -- added missing rows and columns for labels * Better startup performance (possible sdk.js error) (#631) * Update index.html * Update activity.js * fixes #625 -- only push to status block when connected to a print block * fix logic error in status matrix * Fixes #402 Color Issue * fixes #632 -- re-enable block highlighting when running full speed * ensure note block unhighlight's after note plays * refactoring pitch staircase * avoid neg. radius for ellipse * remove console spam; fix typo in status block code * use new div names * ensure widgets hide when opening sampler viewer * fix issue with tying matrix playall to run button * stop playing up and down when close button is clicked * associate more widgets with run button * better integration of playAll button with run button * complete pause before restarting from run button * better debounsing * Scalibility, visibility update for palette background * sync tempo widget with rhythm ruler * use blue instead of white for background strip color * fix background block; refactor palette background color logic * fixes #382 -- fixes #416 -- refactor tempo widget * Default for hertz block (#638) * Popdown palette improved (#639) * refactor pitch slider * updating master * Displaying titles of the palette icons on hover * Remerged with upstream and reapplied the patches * Translation added for text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status block now doesn't get cut from right side. (See image)
(Issue : https://github.com/walterbender/musicblocks/issues/572)