Explicitly style ToolButton insensitive state, fixes #4901 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The insensitive state of ToolButtons was implicitly styled, however newer Gtk+ versions have broken this behaviour. Thanks to @i5o for discovering the correct opacity value.
|
Testing / just in case 😆 / |
|
Tested. Honestly I don't see a real difference between those colors. So, should we merge it? Or wait to calculate the perfeeeeeeect opacity? |
|
@i5o, is it possible in gtk to change the blue opacity seperatly from the other opacity? |
|
By @samdroid-apps http://codepen.io/anon/pen/epEOdm/ Honestly as user I don't see the difference. |
i5o
added a commit
that referenced
this pull request
Oct 10, 2015
Explicitly style ToolButton insensitive state, fixes #4901
|
merged. If we want to be really specifics (¿really needed?) we should find a perfect opacity that returns to #949294. But this works for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insensitive state of ToolButtons was implicitly styled, however
newer Gtk+ versions have broken this behaviour.
Thanks to @i5o for discovering the correct opacity value.
Replaces #77