Modal popups for clipboard (try2) #567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same path if the same journal entry is requested for drag data twice. This means that the old path doesn't get deleted and the clipboard always gets a good path. <http://bugs.sugarlabs.org/ticket/4876>
Currently the clipboard just shows things like "Text Clipping" for journal objects. However, journal objects should have a sense of wholeness and be better repesented in the clipboard [1]. This patch shows metadata about journal objects when they are coppied to the frame. It also shows a resume menu item. Test Cases: * Drag from journal to frame, click resume * Drag journal entry from the frame to the documents folder [1] <wiki.sugarlabs.org/go/Design_Team/Specifications/Clipboard>
samdroid-apps
force-pushed
the
modal-popups-merge
branch
from
ead7b10
to
d5f4a75
Compare
|
I'll split these into some separate patches |
|
@samdroid-apps looks like this can be closed, if everything above was committed |
|
No, this never got committed. However, upon reflection I think that this could be done better. Closing... |
Is there an issue to track that? |
|
I'm not sure, feel free to make one. There is a feature page though: http://wiki.sugarlabs.org/go/Features/Replace_GtkMenu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Page: http://wiki.sugarlabs.org/go/Features/Replace_GtkMenu
Replaces #551
Requires: sugarlabs/sugar-toolkit-gtk3#249 (and therefore sugarlabs/sugar-artwork#69)
See the toolkit pull request for screenshots.
Hopefully I will also have a patch for the journal palettes. But there are treeviews and invokers involved, and those 2 things have never gone well for me 😄