fix missing scroll bar in view source #603
Conversation
|
Still results in X crashing for me on fc20. Happens after it loads the source, but same as before (it loads the code, then it loads more signalled by the scroll bar getting smaller, then crash). Tested on the evil moon activity that caused a crash before. I'm not sure if this patch was meant to fix that, maybe don't include it in the commit message if it wasn't? Otherwise, it doesn't break sugar on fc24 and looks good to me code wise. |
|
Interesting, thanks for the test. I've tested again just now on Fedora 20, and can't fault it. With Moon, Memorize, Measure and Maze. Can you please confirm you have a file /usr/lib/python2.7/site-packages/jarabe/view/viewsource.py with md5sum 3585f26e8afdf99f6ed718b0a597c77d? Can you please save "rpm -qa | sort" into a gist or pastebin and link here? My test system package list is here. |
On Fedora 18, scroll bars were missing, #4903. On Fedora 20, impossible arguments were given to X server, resulting in desktop instability. dev.laptop.org #12872. Regression introduced in 4be3f9e and #4273, in the SourceDisplay class, where a GtkBox is inserted between the GtkScrolledWindow and any child. Fix is - remove GtkBox intermediary; unnecessary, - add methods for managing a single child of the GtkScrolledWindow, which will be either a GtkSourceView or a GtkEventBox in a GtkViewport, - remove some GtkWidget.show calls; made redundant by .show_all,
|
Rebased. |
|
Works great on fc20 XO4. Merging |
On Fedora 18, scroll bars were missing, see 4903. On Fedora 20, impossible arguments were given to X server, resulting in desktop instability, see 12872.
Regression introduced in 4be3f9e and 4273, in the SourceDisplay class, where a GtkBox is inserted between the GtkScrolledWindow and any child.
Fix is