Check for get_icons().props.names absence

[tchx84]

For some unknown reason, some volumes does not
have names property. This cause Journal and Volumes
device icon to break.

Signed-off-by: Martin Abente Lahaye tch@sugarlabs.org

[dnarvaez]

It would be good to know which kind of object icon is. Even if it's not a themed icon it might be an icon we can display...

[dnarvaez]

Might be a GFileIcon for example and we can display that.

[tchx84]

What do you suggest? When the first check fails, test for props.file [1]? and then using that one?

Refs:

1. https://developer.gnome.org/gio/2.36/GFileIcon.html

[dnarvaez]

I'm more suggesting that we need to know more about what is going to come up with a complete fix. What about changing your patch to do something like

icon = self._mount.get_icon()
...
logging.error('Cannot find icon names for %s, %s', icon, str(mount))

And ask Suraj to try it out and post his shell.log. That will tell us the type of icon we are dealing with.

[tchx84]

Sure, will do.

[tchx84]

Whatever we do, we should put it in one place only. So we don't repeat code all over.

[dnarvaez]

I think we should check the icon type using isinstance() and support both GThemedIcon and GFileIcon. It make sense to fallback to a generic icon like you did in your patch as a fallback, if we get a type we don't know about. If supporting GFileIcon is hard I'm fine with just logging an error as a first step.

[tchx84]

I will try to get a cleaner version of the current patch first (using isinstance). Any suggestion on where I could put this _find_icon_name method? Id hate to have 3 copies on this same method.

Regarding using GFileIcon, I need more information about it and determine how much it would affect other parts.