Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the overlapping of 'footer icons' #371

Merged
merged 2 commits into from
Feb 5, 2022
Merged

Conversation

S-kus
Copy link
Contributor

@S-kus S-kus commented Feb 5, 2022

Fixes: #370
As shown below:

  • removed the 'position' style of footer icons in 'airspace.css' to stop overlapping.

  • made footer div responsive by correcting classes in 'footer.html' icons div and aligned code lines correctly after the change (as div are removed).

enhanced

* removed 'position' style of footer icons in 'airspace.css' to stop overlapping

* made footer div responsive by correcting classes in 'footer.html' and aligned code lines correctly after change
Copy link
Contributor

@Raeskaa Raeskaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @S-kus
The changes you've done look great!
but can you also center the last div which contains the copyright note in the end?
image
and then I guess it all will be fine!

@S-kus
Copy link
Contributor Author

S-kus commented Feb 5, 2022

Okay, @Raeskaa I updated it. As shown:

Screenshot from 2022-02-05 23-07-36

Could you please review it once again?

Copy link
Contributor

@Raeskaa Raeskaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks great! :)

@quozl quozl merged commit dbd8f2b into sugarlabs:master Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Footer icons" are overlapping with "contribute to website"
3 participants