feat: Add tid/record-key string format #155
Conversation
sugyan
changed the title
|
@str4d could you review this? |
There was a problem hiding this comment.
utACK'. My intention with the atrium_api::types::string module was for it to contain types in the String Formats list, which record-key is now present in.
| if [".", ".."].contains(&s.as_str()) { | ||
| Err("Disallowed rkey") | ||
| } else if !RE_RKEY | ||
| .get_or_init(|| Regex::new(r"^[a-zA-Z0-9.\-_:~]{1,512}$").unwrap()) |
There was a problem hiding this comment.
I checked that this matches the updated allowed character set, and that \- behaves correctly here.
| @@ -556,7 +555,8 @@ fn string_type(string: &LexString) -> Result<(TokenStream, TokenStream)> { | |||
| Some(LexStringFormat::Handle) => quote!(crate::types::string::Handle), | |||
| Some(LexStringFormat::Nsid) => quote!(crate::types::string::Nsid), | |||
| Some(LexStringFormat::Language) => quote!(crate::types::string::Language), | |||
| // TODO: other formats | |||
There was a problem hiding this comment.
at-uri and uri are still not parsed here yet, so I think this TODO still applies (unless we specifically don't want to parse them here).
| /// [Timestamp Identifier]: https://atproto.com/specs/record-key#record-key-type-tid | ||
| #[derive(Clone, Debug, PartialEq, Eq, Serialize)] | ||
| #[serde(transparent)] | ||
| pub struct Tid(String); |
There was a problem hiding this comment.
Document this as "Added" in the changelog.
| /// A record key (`rkey`) used to name and reference an individual record within the same | ||
| /// collection of an atproto repository. | ||
| #[derive(Debug, Clone, PartialEq, Eq, serde::Serialize)] | ||
| pub struct RecordKey(String); |
There was a problem hiding this comment.
Document this as "Added" in the changelog.
| /// A record key (`rkey`) used to name and reference an individual record within the same | ||
| /// collection of an atproto repository. | ||
| #[derive(Debug, Clone, PartialEq, Eq, serde::Serialize)] | ||
| pub struct RecordKey(String); |
There was a problem hiding this comment.
Document this as "Removed" in the changelog, with a "(moved to string::RecordKey)" note.
|
@str4d Thanks for reviewing! I updated comments and changelogs. |
Resolve #154.
ref: https://atproto.com/specs/record-key
The
RecordKeywas originally defined by @str4d intypes.rs, but has been moved tostring.rsas well as other string formats (including regular expression and test updates due to definition updates). I would like to see if there are any objections to this move.