Increasing maintainability of the code #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be consistent with the others
…. Removed the possibility of creating empty files
…only be constructed once
…o other functions
…() to match new usage
…l year information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My aim here was to break the code into smaller pieces that could be easier to read and easier to maintain, while not changing the underlying functionality. With that in mind, I created two new functions (get_car_details and get_page_html), which are hopefully self-explanatory. I have also replaced the verbose printing with outputting to a logger, allowing the outputs to be extended to multiple levels of detail. I also removed any tabs that were being used for indentation and replaced them with four spaces. Lastly, I added a requirements.txt file to give anyone installing the code a little more information.
I hope to extend this code to provide more information from the searches, but as that will break more with your current approach, I wanted to share this with you first.
Let me know your thoughts and of course happy to discuss improvements or changes to it