Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to standard library portable_simd feature #10

Merged
merged 2 commits into from
Apr 15, 2024
Merged

refactor to standard library portable_simd feature #10

merged 2 commits into from
Apr 15, 2024

Conversation

KonradHoeffner
Copy link
Contributor

As packed_simd no longer works with Rust nightly 1.78 (see rust-lang/packed_simd#359), this PR tries to refactor to the nightly-only portable_simd feature.

Warning I am not a SIMD expert and while it builds, some tests still fail, however I cannot find the reason right now.
I also used transmute, so this should go through a thorough review.

@KonradHoeffner KonradHoeffner marked this pull request as ready for review March 6, 2024 09:44
@KonradHoeffner
Copy link
Contributor Author

@sujayakar: Could you take a look into this PR? If this got merged this could help resolve several open issues in other projects.

@sujayakar
Copy link
Owner

hey @KonradHoeffner, sorry for the delay getting back to you. I don't currently have an x64 machine for work anymore, so I had to get a dev setup up and running on my gaming PC (AMD Zen2).

the PR overall looks good, and I wasn't getting any test failures when I patched it in locally. In particular, I did

$ QUICKCHECK_TESTS=10000 cargo test --release --features simd qc_rsdict

and the tests passed. what failures are you running into?

@Cydhra
Copy link
Contributor

Cydhra commented Apr 14, 2024

The failures have been fixed by ee11266

@KonradHoeffner
Copy link
Contributor Author

@sujayakar Thanks for looking into this! I've recently refactored our library to use sucds instead but I'm sure this will be helpful for a lot of other users. Yes, @Cydhra fixed all the errors.

@sujayakar sujayakar merged commit 78c3841 into sujayakar:master Apr 15, 2024
@sujayakar
Copy link
Owner

thanks for the fixes! I'll do a crates.io release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants