This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
Upgrade to Rails 5.1 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In so doing, dump the about_page dependency which is not compatible with the latest Rails versions. Instead, use okcomputer. Also, dump isitworking because okcomputer serves the same purpose. Refs #72
mjgiarlo
force-pushed
the
rails5.1_issue72
branch
from
86d4a94
to
3d72077
Compare
peetucket
approved these changes
Dec 7, 2018
mjgiarlo
added a commit
to sul-dlss-deprecated/dor-fetcher
that referenced
this pull request
Dec 11, 2018
Required by sul-dlss-deprecated/dor-fetcher-service#75, which upgraded dor-fetcher-service to Rails 5.1 and replaced about_page and isitworking with okcomputer. Reflect this change in the implementation and the tests.
jcoyne
pushed a commit
to sul-dlss-deprecated/dor-fetcher
that referenced
this pull request
Dec 11, 2018
Depend on okcomputer-like behavior in dor-fetcher-service Required by sul-dlss-deprecated/dor-fetcher-service#75, which upgraded dor-fetcher-service to Rails 5.1 and replaced about_page and isitworking with okcomputer. Reflect this change in the implementation and the tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In so doing...
about_pagedependency which is not compatible with the latest Rails versionsokcomputerinstead ofabout_pageisitworkingbecauseokcomputerserves the same purposeGemfileand collapse redundant gem groupstzinfo-datadependency since app does not require being deployed to Windows or JVM environmentsVERSIONRefs #72