This repository has been archived by the owner on May 28, 2024. It is now read-only.
[HOLD] Update sw_format_ssim to stanford_mods_record.format_main #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-collier
force-pushed
the
t992a-sw-format-facet
branch
from
c2aeea0
to
1214429
Compare
jmartin-sul
approved these changes
Sep 26, 2023
mjgiarlo
suggested changes
Sep 28, 2023
aaron-collier
changed the title
7 tasks
|
Specs make it look like "it's opposite day!" -- this seems to show significant logic differences between straight cocina indexing and stanford-mods indexing. |
|
ACTION ITEM per discussion with @andrewjbtw @ndushay and @aaron-collier on 10/3/23: Aaron will write "report" tickets for sussing out the differences between stanford mods indexing and dor-indexing-app for this part of descriptive metadata. |
ndushay
changed the title
ndushay
changed the title
|
waiting for cocina-models release with a patch, then reverting back to what it was doing and skipping this??? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
Part of #992 - updates the
sw_format_ssimfacet.Depends on: sul-dlss/cocina-models#626
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact, run integration tests that exercise indexing (e.g. searches in Argo for newly created/updated items, access_indexing_spec) and/or test in [stage|qa] environment, in addition to specs. ⚡