Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

[HOLD - doing report first] Update sw_subject_geographic_ssim to use stanford-mods.subjects.geographic_facet #1010

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaron-collier
Copy link
Contributor

@aaron-collier aaron-collier commented Sep 25, 2023

HOLD - see sul-dlss/dor-services-app#4611 which is a report to compare values coming from cocina with values coming from stanford-mods ... so we can see whether we should do this or not.

Why was this change made? 🤔

Part of #992

How was this change tested? 🤨

⚡ ⚠ If this change has cross service impact, run integration tests that exercise indexing (e.g. searches in Argo for newly created/updated items, access_indexing_spec) and/or test in [stage|qa] environment, in addition to specs. ⚡

@@ -24,7 +24,7 @@ def to_solr
'contributor_orcids_ssim' => orcids,
'sw_display_title_tesim' => title,
'sw_subject_temporal_ssim' => subject_temporal,
'sw_subject_geographic_ssim' => subject_geographic,
'sw_subject_geographic_ssim' => stanford_mods_record.geographic_facet.uniq,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all the test changes below are negative tests now. What does the change now map to?

@ndushay ndushay changed the title Update sw_subject_geographic_ssim to use Stanford::Mods::SearchworksS… [HOLD] Update sw_subject_geographic_ssim to use Stanford::Mods::SearchworksS… Oct 3, 2023
@ndushay
Copy link
Contributor

ndushay commented Oct 3, 2023

Specs make it look like "it's opposite day!" -- this seems to show significant logic differences between straight cocina indexing and stanford-mods indexing.

Copy link
Contributor

@ndushay ndushay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not merge until the world is a better place.

@ndushay
Copy link
Contributor

ndushay commented Oct 3, 2023

ACTION ITEM per discussion with @andrewjbtw @ndushay and @aaron-collier on 10/3/23: Aaron will write "report" tickets for sussing out the differences between stanford mods indexing and dor-indexing-app for this part of descriptive metadata.

@ndushay ndushay changed the title [HOLD] Update sw_subject_geographic_ssim to use Stanford::Mods::SearchworksS… [HOLD - doing report first] Update sw_subject_geographic_ssim to use Stanford::Mods::SearchworksS… Oct 5, 2023
@ndushay ndushay changed the title [HOLD - doing report first] Update sw_subject_geographic_ssim to use Stanford::Mods::SearchworksS… [HOLD - doing report first] Update sw_subject_geographic_ssim to use stanford-mods.subjects.geographic_facet Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants