This repository has been archived by the owner on Mar 14, 2022. It is now read-only.
Use a custom type for RecordNotFound errors #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcoyne unfortunately needs a rebase but otherwise lgtm / i'm ready to approve |
jcoyne
force-pushed
the
typedError
branch
2 times, most recently
from
01ad703
to
cbe6fd9
Compare
eefahy
approved these changes
Apr 25, 2018
cmharlow
approved these changes
Apr 26, 2018
aaron-collier
approved these changes
Apr 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.