This repository has been archived by the owner on Mar 14, 2022. It is now read-only.
Add agreement as a distinct type #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
changed the title
jcoyne
force-pushed
the
agreementValidator
branch
2 times, most recently
from
754838d
to
013f7ec
Compare
jcoyne
force-pushed
the
agreementValidator
branch
6 times, most recently
from
2c5c10c
to
7c91b7c
Compare
Adds a validator to ensure the structural.hasAgreement actually points at an agreement. Fixes #383
This reduces the number of log lines we see.
jcoyne
force-pushed
the
agreementValidator
branch
from
7c91b7c
to
003d921
Compare
aaron-collier
approved these changes
Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a validator to ensure the structural.hasAgreement actually points
at an agreement.
Fixes #383