This repository has been archived by the owner on Mar 14, 2022. It is now read-only.
Set created and lastUpdated #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
timestamps
branch
2 times, most recently
from
5d27205
to
dba9727
Compare
aaron-collier
approved these changes
Apr 25, 2018
cmharlow
approved these changes
Apr 26, 2018
| @@ -58,6 +59,7 @@ func (d *depositResource) Handle(params operations.DepositResourceParams, agent | |||
| WithID(uuid). | |||
| WithExternalIdentifier(externalID). | |||
| WithVersion(1) | |||
| (*resource.Administrative())["created"] = time.Now().UTC().Format(time.RFC3339) | |||
There was a problem hiding this comment.
@eefahy did you / we ever move the ball on capturing or using the dynamodb datetime created for the sake of this admin field? i think you said it was captured, it was just a question of putting it in the metadata or resource responses for sake of clients + users.
There was a problem hiding this comment.
never mind, dynamodb date is unreliable.
cmharlow
suggested changes
Apr 26, 2018
eefahy
approved these changes
Apr 26, 2018
|
note this doesn't add admin metadata for File metadata. |
cmharlow
approved these changes
Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408